Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPP to recusively fetch last recorded derived sample UDF #384

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

kedhammar
Copy link

The requested application is for ONT libraries, to be able to assign the last recorded size from the library prep in the aggregate QC.

The script is written in a general way though, so it can be applied in other places if needed.

Uses recusive API acrobatics. Tested on Stage for both QC and non-QC steps.

@kedhammar kedhammar requested a review from alneberg December 20, 2024 12:41
@kedhammar kedhammar self-assigned this Dec 20, 2024
@kedhammar
Copy link
Author

@alneberg please let me know if you think this should be a validation / verification.

For everyone doing library QC at NGI, the aggregate QC step will have

  • A blue button "Fetch last known field"
  • A step field "Fetch last known", with a drop-down selection specifying what to fetch
  • A file slot, "Fetch last known field Log"

but it won't really affect anything unless it's manually run. And even if it's run accidentally, it should only affect the fields within the step, which can in turn be cleared, re-written and repopulated by running the regular aggregate QC scripts to fetch the field values from the QC steps.

@kedhammar
Copy link
Author

Test steps

@kedhammar
Copy link
Author

More test steps whose EPPs are impacted by the code changes

@kedhammar
Copy link
Author

I ended up re-writing the function for recursive UDF fetching. This expanded the scope of the PR significantly, but I've attached tests on Stage that I feel cover the changes.

By my account, the only thing touching the accredited scope should be the Zika pooling.

Ready for re-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant