ContainerProtocol.register returns self #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Y'all may have a reason for not defining the return type of
ContainerProtocol.register
, but if so, I didn't pick up on it.Here I propose making
ContainerProtocol.register
returnSelf
. This matches whatContainer.register
does and allows a chaining of registrations of likeHonestly, I don't care and am equally happy with
None
, but a tighter bound thanAny
seems beneficial to maintaining portability across container implementations.