Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging #1

Merged
merged 6 commits into from
Mar 24, 2021
Merged

Add logging #1

merged 6 commits into from
Mar 24, 2021

Conversation

mfrata
Copy link
Collaborator

@mfrata mfrata commented Mar 22, 2021

@ryukinix and @brenocosta0901

I've finished a first version of the lodge lib. We can tweak it from this state!

To test, download this example project myproject.zip, and create a virtuavenv. Install it and run myproj_bin

Follow the readme to test all the features!

@mfrata mfrata requested a review from ryukinix March 22, 2021 14:01
@mfrata mfrata self-assigned this Mar 22, 2021
@ryukinix
Copy link

Cool!

@ryukinix ryukinix requested a review from a team March 22, 2021 16:23
Copy link

@ryukinix ryukinix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very simple software! I liked the simplicity. I made some questions and suggestions, but the overall implementation seems great to me.

.github/workflows/actions.yml Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Makefile Show resolved Hide resolved
lodge.py Outdated Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@breno-costa breno-costa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job as usual :) This package is really very easy to use.

I've tested all documented examples, and they worked as described.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
lodge.py Show resolved Hide resolved
lodge.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@ryukinix ryukinix added this to the 0.1.0 milestone Mar 23, 2021
lodge.py Show resolved Hide resolved
Copy link

@ryukinix ryukinix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About what I asked for before, this implementations looks good to me. Let's wait to resolve the @brenocosta0901 suggestions until merge.

Copy link
Collaborator

@breno-costa breno-costa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfrata LGTM

@mfrata mfrata merged commit 1529caa into main Mar 24, 2021
@mfrata mfrata deleted the add-logging branch March 24, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants