-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging #1
Add logging #1
Conversation
Cool! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very simple software! I liked the simplicity. I made some questions and suggestions, but the overall implementation seems great to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job as usual :) This package is really very easy to use.
I've tested all documented examples, and they worked as described.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About what I asked for before, this implementations looks good to me. Let's wait to resolve the @brenocosta0901 suggestions until merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mfrata LGTM
@ryukinix and @brenocosta0901
I've finished a first version of the lodge lib. We can tweak it from this state!
To test, download this example project myproject.zip, and create a virtuavenv. Install it and run
myproj_bin
Follow the readme to test all the features!