Merge pull request #191 from nicholashagen/update-inflight-metrics-wh…

…en-rejected Ensure the inflight metrics are properly updated when rejecting
Netflix · Jan 17, 2024 · 291d7bb · 291d7bb
2 parents 5522e3d + 1c486a9
commit 291d7bb
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/...rency-limits-core/src/main/java/com/netflix/concurrency/limits/limiter/SimpleLimiter.java b/...rency-limits-core/src/main/java/com/netflix/concurrency/limits/limiter/SimpleLimiter.java
@@ -49,12 +49,16 @@ public SimpleLimiter(AbstractLimiter.Builder<?> builder) {
 
     @Override
     public Optional<Limiter.Listener> acquire(ContextT context) {
+        Optional<Limiter.Listener> listener;
         if (!semaphore.tryAcquire()) {
-            return createRejectedListener();
+            listener = createRejectedListener();
         }
-        Listener listener = new Listener(createListener());
+        else {
+            listener = Optional.of(new Listener(createListener()));
+        }
+
         inflightDistribution.addSample(getInflight());
-        return Optional.of(listener);
+        return listener;
     }
 
     @Override