feat: update documentation for SSE subscriptions and update configura… #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion documentation to include new configuration items.
9 tasks
srinivasankavitha
requested changes
Jul 5, 2022
|
Thanks for the doc updates! |
|
Yes, but not the new graphql-ws. The older `subscriptions-transport-ws` is
what is currently still in the framework.
…On Tue, Jul 5, 2022 at 10:30 AM Ancient-Dragon ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/advanced/subscriptions.md
<#100 (comment)>:
> @@ -29,21 +29,30 @@ A complete example can be found [in `SubscriptionDatafetcher.java`](https://gith
The GraphQL specification doesn't specify a transport protocol.
WebSockets are the most popular transport protocol however, and are supported by the DGS Framework.
-Apollo defines a [sub-protocol](https://github.com/apollographql/subscriptions-transport-ws/blob/master/PROTOCOL.md), which is supported by client libraries and implemented by the DGS framework.
+Apollo defines a [sub-protocol](https://github.com/enisdenjo/graphql-ws/blob/master/PROTOCOL.md), which is supported by client libraries and implemented by the DGS framework.
Not sure what you mean here, I thought DGS supported websockets?
—
Reply to this email directly, view it on GitHub
<#100 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ5JPXIVAXHZRHET264JF3DVSRWK7ANCNFSM52RCLJYQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Ah ak in which case I will update the documentation to make that clear and revert that change. |
|
Done |
srinivasankavitha
approved these changes
Apr 8, 2023
|
I just noticed this PR - the dgs framework actually implements a slightly different protocol based on https://github.com/CodeCommission/subscriptions-transport-sse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion documentation to include new configuration items.