Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync from L1 #1335

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Sync from L1 #1335

wants to merge 2 commits into from

Conversation

joshklop
Copy link
Contributor

@joshklop joshklop commented Oct 12, 2023

The diff is nicer than it looks. Maybe ~500 lines of actual code, only ~100 of which is interesting/bug-prone.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: Patch coverage is 68.31502% with 173 lines in your changes missing coverage. Please review.

Project coverage is 72.75%. Comparing base (3d4f630) to head (b59bca2).
Report is 379 commits behind head on main.

Files with missing lines Patch % Lines
syncl1/syncl1.go 52.45% 46 Missing and 12 partials ⚠️
l1data/l1data.go 73.86% 36 Missing and 16 partials ⚠️
cmd/juno/juno.go 17.50% 33 Missing ⚠️
syncl1/iterator.go 60.00% 12 Missing and 6 partials ⚠️
l1data/fetcher.go 53.84% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1335      +/-   ##
==========================================
- Coverage   72.95%   72.75%   -0.20%     
==========================================
  Files          96      104       +8     
  Lines        9997    10559     +562     
==========================================
+ Hits         7293     7682     +389     
- Misses       2163     2298     +135     
- Partials      541      579      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshklop joshklop force-pushed the joshklop/sync-from-l1 branch 2 times, most recently from e8ae0e8 to c57d182 Compare October 23, 2023 08:17
@joshklop joshklop marked this pull request as ready for review October 23, 2023 08:19
@joshklop joshklop requested review from a team and IronGauntlets and removed request for a team October 23, 2023 08:19
@joshklop joshklop force-pushed the joshklop/sync-from-l1 branch 2 times, most recently from 7458786 to 48dfe94 Compare October 25, 2023 16:32
@joshklop joshklop requested review from omerfirmak and removed request for IronGauntlets December 11, 2023 13:19
@joshklop joshklop force-pushed the joshklop/sync-from-l1 branch 2 times, most recently from 3b7b3d3 to b59bca2 Compare December 13, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants