Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement logic to build genesis state for the sequencer #2371

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

rianhughes
Copy link
Contributor

@rianhughes rianhughes commented Jan 13, 2025

This PR implements the genesis pkg that builds a state diff from declaring classes, deploying contracts and invoking functions. The sequencer can then commit this state diff to state, so that upon startup, a set of account contracts have already been deployed and funded (it is not possible to achieve this from an empty state by submitting transactions, since Starknet requires accounts to be funded to perform any actions on the state - originally this wasn't a requirement in Starknet). This is particularly useful as it allows users to start the sequencer with any number of accounts pre-deployed, and pre-funded, etc, and opens up the possibility of using Juno as a devnet

In essence:

  1. we load classes, then declare them,
  2. execute the constructor functions using the vm, which writes the changes to the pending state
  3. execute any functions of interest (eg token transfers) using the vm (where similarly the vm writes the changes to the pending state)
  4. extract the state-diff and new classes from the pending state.

@rianhughes rianhughes marked this pull request as draft January 13, 2025 12:29
@rianhughes rianhughes force-pushed the feature/sequencer-genesis branch from fb11e07 to 459db5d Compare January 13, 2025 14:37
@rianhughes rianhughes marked this pull request as ready for review January 13, 2025 14:38
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 65.54054% with 102 lines in your changes missing coverage. Please review.

Project coverage is 74.52%. Comparing base (21f442f) to head (41bd928).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
genesis/genesis.go 65.14% 42 Missing and 19 partials ⚠️
adapters/vm2core/vm2core.go 55.00% 14 Missing and 4 partials ⚠️
sync/pending.go 70.58% 13 Missing and 2 partials ⚠️
core/state_update.go 73.91% 5 Missing and 1 partial ⚠️
node/throttled_vm.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2371      +/-   ##
==========================================
- Coverage   74.74%   74.52%   -0.23%     
==========================================
  Files         111      112       +1     
  Lines       12581    12871     +290     
==========================================
+ Hits         9404     9592     +188     
- Misses       2480     2554      +74     
- Partials      697      725      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

genesis/genesis.go Outdated Show resolved Hide resolved
core/state_update.go Outdated Show resolved Hide resolved
adapters/vm2core/vm2core.go Outdated Show resolved Hide resolved
sync/pending.go Outdated Show resolved Hide resolved
sync/pending.go Outdated Show resolved Hide resolved
Copy link
Contributor

@AnkushinDaniil AnkushinDaniil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have finished reviewing everything except vm logic. Everything is good, just small changes and questions. I'll continue reviewing vm logic.

adapters/vm2core/vm2core.go Outdated Show resolved Hide resolved
core/state_update.go Show resolved Hide resolved
genesis/genesis.go Outdated Show resolved Hide resolved
genesis/genesis.go Outdated Show resolved Hide resolved
genesis/genesis.go Show resolved Hide resolved
genesis/genesis.go Outdated Show resolved Hide resolved
genesis/genesis.go Outdated Show resolved Hide resolved
genesis/genesis.go Outdated Show resolved Hide resolved
sync/pending.go Show resolved Hide resolved
core/state_update.go Show resolved Hide resolved
adapters/vm2core/vm2core.go Outdated Show resolved Hide resolved
core/state_update.go Show resolved Hide resolved
genesis/genesis.go Show resolved Hide resolved
genesis/genesis.go Outdated Show resolved Hide resolved
genesis/genesis.go Outdated Show resolved Hide resolved
sync/pending.go Outdated Show resolved Hide resolved
genesis/genesis.go Show resolved Hide resolved
vm/rust/src/lib.rs Show resolved Hide resolved
@cicr99
Copy link

cicr99 commented Jan 24, 2025

Even though the PR is approved, I'm adding the blocked label up until all the changes regarding the new blockifier release are finished. This takes priority and will probably cause conflicts with the changes done to the vm pkg in this PR.

@cicr99 cicr99 added blocked Depends on another to be solved first Sequencer labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Depends on another to be solved first Sequencer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants