Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prescription extraction fixes and improvements #62

Merged
merged 4 commits into from
Sep 8, 2024

Conversation

lucy-schick
Copy link
Collaborator

@lucy-schick lucy-schick commented Aug 30, 2024

Turns out that the first ncfdc_1998_prescriptions_clean.csv was pretty draft and there were lots of things to fix.

https://github.com/NewGraphEnvironment/restoration_wedzin_kwa_2024/blob/main/scripts/extract-tables-ncfdc-1998.R was the script used to make that csv, I'm pretty sure I wrote the prescription part and I remember it being pretty rough. Anyhow, cleaned it up big time.

I made a new script called extract-prescriptions-ncfdc-1998.R and copied over the old code from extract-tables-ncfdc-1998.R. Now extract-prescriptions-ncfdc-1998.R contains all the code to extract the prescriptions. I removed the old code from extract-tables-ncfdc-1998.R which now only contains code to extract tables (makes sense to me with the name).

A couple changes to the new extract-prescriptions-ncfdc-1998.R :

I did run through https://github.com/NewGraphEnvironment/restoration_wedzin_kwa_2024/blob/main/scripts/extract-tables-ncfdc-prescription-elements.R which was helpful but https://github.com/NewGraphEnvironment/restoration_wedzin_kwa_2024/blob/main/scripts/extract-tables-ncfdc-1998.R had more of what we needed

Can close #48 once this is merged.

Need to go reopen #45 once this is merged because I accidentally put the wrong issue number in the commit, see #45 (comment)

@NewGraphEnvironment
Copy link
Owner

Awesome. Thanks!

Will be interesting to see what is different between what we have extracted here and the files dug up from SKT that are on the google drive link. Will turn this into a spatial file ASAP and add to the project in the meantime. Wonderful!!!!

@NewGraphEnvironment NewGraphEnvironment merged commit 580d0e1 into NewGraphEnvironment:main Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restoration sites historic - Prescriptions - Regional District of Nadina - Community Futures
2 participants