Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IR: Easy Learn [Bugfix] #360

Merged
merged 31 commits into from
Jan 23, 2025
Merged

IR: Easy Learn [Bugfix] #360

merged 31 commits into from
Jan 23, 2025

Conversation

jaylikesbunda
Copy link
Contributor

@jaylikesbunda jaylikesbunda commented Jan 22, 2025 •
edited by Willy-JL
Loading

What's new

  • current_button_index was not reset when starting a new remote causing the learn screen to still display power after one skip only after initial app launch

so power > power > vol_up
but only on first learn after launch of the app

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

jaylikesbunda and others added 30 commits January 12, 2025 21:49
@jaylikesbunda
initial working commit
ed80457
@jaylikesbunda
update names + format
1a12840
@jaylikesbunda
add skip functionality
08d342a
@jaylikesbunda
misc tweaks
3ef4488
@jaylikesbunda
change back gpio label
7057463
@jaylikesbunda
remove gpio setting changes
1be14dd
@jaylikesbunda
misc fixes
ef9d868
@jaylikesbunda
bug fixes and polish
2a35845
@jaylikesbunda
add subtitle button and reorganize order
ec1b999
@jaylikesbunda
Merge branch 'Next-Flip:dev' into infrared-learn
5b54a76
@jaylikesbunda
update ir settings to version 2
342eb3f
@jaylikesbunda
ir settings v1 migration support
213733f
@jaylikesbunda
fixes
ce8e73e
@jaylikesbunda
Merge branch 'Next-Flip:dev' into infrared-learn
b742475
@jaylikesbunda
format
3fc0fdb
@jaylikesbunda
Merge branch 'infrared-learn' of https://github.com/jaylikesbunda/Mom…
dd13d4a 
…entum-Firmware into infrared-learn
@jaylikesbunda
misc fixes
c75f008
@Willy-JL
Merge remote-tracking branch 'mntm/dev' into mntm-pr-350
837b9ca
@Willy-JL
Simplify and standardize settings handling
868d286
@Willy-JL
Auto-calculate easy_mode_button_count
358877c
@Willy-JL
Case insensitive match existing remote buttons
8198929
@Willy-JL
Display button name more prominently
1419f2d
@Willy-JL
Sort submenu indexes and handling
c4abc30
@Willy-JL
Fine to keep text highlighted
cfaf24e
@Willy-JL
Some formatting for less conflicts
5c889d0
@Willy-JL
Not sure how these got lost kek
e602109
@Willy-JL
Update changelog
1a376a5
@jaylikesbunda
reset index count when starting new remote
0cf07c7
@jaylikesbunda
Merge branch 'Next-Flip:dev' into infrared-learn
a0ccd10
@jaylikesbunda
Merge branch 'infrared-learn' of https://github.com/jaylikesbunda/Mom…
59e9c06 
…entum-Firmware into infrared-learn
@Willy-JL Willy-JL added the bugfix Something isn't working label Jan 23, 2025
@Willy-JL Willy-JL merged commit 7713eb8 into Next-Flip:dev Jan 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willy-JL Willy-JL Willy-JL approved these changes

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich is a code owner

@956MB 956MB Awaiting requested review from 956MB 956MB is a code owner

Assignees

@jaylikesbunda jaylikesbunda

Labels
bugfix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaylikesbunda @Willy-JL