-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt reduced motion settings in more places #1760
Open
nishanthkarthik
wants to merge
3
commits into
Nheko-Reborn:master
Choose a base branch
from
nishanthkarthik:theme
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,131 @@ | ||
| // SPDX-FileCopyrightText: Nheko Contributors | ||
| // | ||
| // SPDX-License-Identifier: GPL-3.0-or-later | ||
|
|
||
| import QtQuick 2.15 | ||
|
|
||
| Item { | ||
| id: ripple | ||
|
|
||
| property color color: "#22000000" | ||
| property real maxRadius: Math.max(width, height) | ||
| readonly property real radiusAnimationRate: 0.05 | ||
| readonly property real radiusTailAnimationRate: 0.5 | ||
| readonly property real opacityAnimationDuration: 300 | ||
| property var rippleTarget: parent | ||
|
|
||
| anchors.fill: parent | ||
|
|
||
| PointHandler { | ||
| id: ph | ||
|
|
||
| onGrabChanged: (_, point) => { | ||
| circle.centerX = point.position.x | ||
| circle.centerY = point.position.y | ||
| } | ||
|
|
||
| target: Rectangle { | ||
| id: backgroundLayer | ||
| parent: rippleTarget | ||
|
|
||
| anchors.fill: parent | ||
| color: "transparent" | ||
| clip: true | ||
|
|
||
| Rectangle { | ||
| id: circle | ||
|
|
||
| property real centerX | ||
| property real centerY | ||
|
|
||
| x: centerX - radius | ||
| y: centerY - radius | ||
|
|
||
| height: radius*2 | ||
| width: radius*2 | ||
| radius: 0 | ||
| color: ripple.color | ||
|
|
||
| state: ph.active ? "ACTIVE" : "NORMAL" | ||
| states: [ | ||
| State { | ||
| name: "NORMAL" | ||
| }, | ||
| State { | ||
| name: "ACTIVE" | ||
| } | ||
| ] | ||
| transitions: [ | ||
| Transition { | ||
| from: "NORMAL" | ||
| to: "ACTIVE" | ||
| enabled: !Settings.reducedMotion | ||
|
|
||
| SequentialAnimation { | ||
| //PropertyAction { target: circle; property: "centerX"; value: ph.point.position.x } | ||
| //PropertyAction { target: circle; property: "centerY"; value: ph.point.position.y } | ||
| PropertyAction { target: circle; property: "visible"; value: true } | ||
| PropertyAction { target: circle; property: "opacity"; value: 1 } | ||
|
|
||
| NumberAnimation { | ||
| id: radius_animation | ||
|
|
||
| target: circle | ||
| properties: "radius" | ||
| from: 0 | ||
| to: ripple.maxRadius | ||
| duration: ripple.maxRadius / ripple.radiusAnimationRate | ||
|
|
||
| easing { | ||
| type: Easing.OutQuad | ||
| } | ||
|
|
||
| } | ||
|
|
||
| } | ||
|
|
||
| }, | ||
| Transition { | ||
| from: "ACTIVE" | ||
| to: "NORMAL" | ||
| enabled: !Settings.reducedMotion | ||
|
|
||
| SequentialAnimation { | ||
| ParallelAnimation { | ||
| NumberAnimation { | ||
| id: radius_tail_animation | ||
|
|
||
| target: circle | ||
| properties: "radius" | ||
| to: ripple.maxRadius | ||
| duration: ripple.maxRadius / ripple.radiusTailAnimationRate | ||
|
|
||
| easing { | ||
| type: Easing.Linear | ||
| } | ||
|
|
||
| } | ||
|
|
||
| NumberAnimation { | ||
| id: opacity_animation | ||
|
|
||
| target: circle | ||
| properties: "opacity" | ||
| to: 0 | ||
| duration: ripple.opacityAnimationDuration | ||
|
|
||
| easing { | ||
| type: Easing.InQuad | ||
| } | ||
|
|
||
| } | ||
|
|
||
| } | ||
| PropertyAction { target: circle; property: "visible"; value: false } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally we were told that fade effects are fine for reducedMotion, which is why we didn't disable those. Do you have a reason to do otherwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I mechanically disabled all transitions when reducedMotion is enabled. Are there any specific instances where you'd like to keep these? My motivation for disabling transitions is poor performance - on nvidia-wayland, the transitions stutter sometimes on a fairly powerful gpu (1060).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the reduced motion setting not because of stutter, we have them to provide a usable experience to people, who get dizzy when stuff on their screen moves. That's why we use fade animations instead. The stutter could probably be easily fixed by figuring out why it stutters, it is very unlikely to be related to your GPU struggling, but probably more because Nheko blocks the UI thread with database work or so.