Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade graphql #387

Merged
merged 1 commit into from
Nov 5, 2024
Merged

chore: upgrade graphql #387

merged 1 commit into from
Nov 5, 2024

Conversation

CalicoNino
Copy link
Contributor

@CalicoNino CalicoNino commented Nov 5, 2024

Mitigate GraphQL Vulnerabilities, brought up by ecosystem projects

Summary by CodeRabbit

  • New Features
    • Upgraded dependencies for graphql and graphql-ws, potentially introducing new features and improvements.
  • Bug Fixes
    • Updated libraries may include bug fixes that enhance overall application stability and performance.

@CalicoNino CalicoNino self-assigned this Nov 5, 2024
@CalicoNino CalicoNino requested a review from cgilbe27 November 5, 2024 17:56
Copy link
Contributor

coderabbitai bot commented Nov 5, 2024

Walkthrough

The pull request updates the package.json file for the @nibiruchain/nibijs project by modifying the versions of the graphql and graphql-ws dependencies. Specifically, the graphql package version is increased from ^16.7.1 to ^16.9.0, and the graphql-ws package version is raised from ^5.14.0 to ^5.16.0. These changes are applied in both the dependencies and peerDependencies sections without altering the overall structure of the package.json.

Changes

File Change Summary
package.json Updated versions of graphql from ^16.7.1 to ^16.9.0 and graphql-ws from ^5.14.0 to ^5.16.0 in both dependencies and peerDependencies.

Possibly related PRs

  • chore: upgrading cosmjs #352: This PR involves updates to the package.json file for dependency version changes, similar to the main PR's focus on upgrading the graphql and graphql-ws packages.

Suggested labels

released

🐇 In the garden, I hop with glee,
Dependencies updated, oh what a spree!
GraphQL and friends, now fresh and bright,
Upgraded versions, a joyful sight!
Hopping along, we celebrate this day,
With better code, we bound on our way! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9d7ff5c and 6336890.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json (1 hunks)
🔇 Additional comments (2)
package.json (2)

49-49: Verify graphql-ws compatibility.

The upgrade of graphql-ws to v5.16.0 aligns well with the GraphQL upgrade. This is a compatible minor version bump.

Let's verify the compatibility between these versions:

✅ Verification successful

Based on the output, I can generate the final response as we have received the peer dependency information showing that [email protected] is compatible with graphql versions >=0.11 <=16.

✓ graphql-ws v5.16.0 is compatible with graphql v16.9.0

The peer dependency check confirms that graphql-ws v5.16.0 supports graphql versions up to v16, making it fully compatible with graphql v16.9.0 used in this project.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if graphql-ws v5.16.0 is compatible with graphql v16.9.0

echo "Checking graphql-ws peer dependencies..."
npm info [email protected] peerDependencies

Length of output: 465


48-48: Verify security fix in GraphQL v16.9.0.

The upgrade from v16.7.1 to v16.9.0 is a step in the right direction to address the security vulnerabilities. The version is consistently updated in both dependencies and peerDependencies.

Let's verify if this version specifically addresses the reported vulnerabilities:

Also applies to: 57-57


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Nov 5, 2024

Lines Statements Branches Functions
Coverage: 94%
95.42% (876/918) 80.66% (171/212) 94.04% (300/319)

@CalicoNino CalicoNino merged commit d707e12 into develop Nov 5, 2024
3 checks passed
@CalicoNino CalicoNino deleted the chore/upgrade-graphql branch November 5, 2024 18:16
CalicoNino added a commit that referenced this pull request Nov 20, 2024
* chore: update eth proto to latest

* refactor: updating to latest graphql schema since featureflags don't include spot & perp (#385)

* fix: test

* fix: test

* chore: upgrade graphql (#387)

* refactor: adding eth & tokenfactory types (#389)

* refactor: adding eth & tokenfactory types

* chore: remove test file

* fix: typo

* refactor: wasmclient doesn't need nibi registry

---------

Co-authored-by: Calico Nino <[email protected]>
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
### [5.0.3](v5.0.2...v5.0.3) (2024-11-20)

### Miscellaneous Chores

* develop -> main ([#388](#388)) ([24ea6e8](24ea6e8)), closes [#385](#385) [#387](#387) [#389](#389)

 [skip ci]
github-actions bot pushed a commit that referenced this pull request Dec 2, 2024
## [6.0.0](v5.0.3...v6.0.0) (2024-12-02)

### Bug Fixes

* test ([9d7ff5c](9d7ff5c))
* test ([e0b49c9](e0b49c9))

### Miscellaneous Chores

* update eth proto to latest ([96014f2](96014f2))
* upgrade graphql ([#387](#387)) ([d707e12](d707e12))

### Code Refactors

* adding eth & tokenfactory types ([#389](#389)) ([8c6c34c](8c6c34c))
* updating to latest graphql schema since featureflags don't include spot & perp ([#385](#385)) ([cbb36d7](cbb36d7))

 [skip ci]
@nibibot
Copy link

nibibot commented Dec 2, 2024

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants