Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for font adjustment #222

Open
ahangarha opened this issue Feb 22, 2020 · 25 comments
Open

Add option for font adjustment #222

ahangarha opened this issue Feb 22, 2020 · 25 comments
Labels
feature request request for a new feature

Comments

@ahangarha
Copy link
Contributor

Depending on screen size and resolution, users may need to adjust font size. Also, they may prefer using a custom font.

It would be great to have these options available.


I already compile my own version with customized font (Vazir 13px)

@NicolasConstant
Copy link
Owner

Changing the font dynamically might not be trivial, unless I find a trick. :/

Changing the scaling ratio in the contrary (for OS that still don't provide factional dpi scaling...) would be easy on the electron build. I might implement this last one first.

@NicolasConstant NicolasConstant added the feature request request for a new feature label Feb 25, 2020
@ahangarha
Copy link
Contributor Author

I will check it too

@yannicka
Copy link
Contributor

yannicka commented May 24, 2020

I made a PR (#286) in order to be able to zoom the application. Does this meet your needs?

@ahangarha
Copy link
Contributor Author

It can help I guess but not sure.

Anyway zoom feature is already needed.

@NicolasConstant
Copy link
Owner

Scaling for me is a bit different than changing the font size only. So I wouldn't close this one when adding scaling support.

But of course it's still a nice addition!

@nullbasis
Copy link

Here to throw my support behind a font size option. It's incredibly small on my screen.

@NicolasConstant
Copy link
Owner

If you are using the desktop app you can increase the scale and the fonts by the same time:

image
(hit Alt key to show the toolbar)

@nullbasis
Copy link

The tool bar was not intuitive at all, but it did let me zoom in, thanks. But Ctrl++ and Ctrl+- do nothing, which is why I assumed there was no way to zoom in.

@NicolasConstant
Copy link
Owner

NicolasConstant commented Nov 23, 2020

The tool bar was not intuitive at all

It was a request from another user: to mimic the behavior of other tools that are doing the same (like Firefox). In one way it does make the app cleaner/more modern, on the other hand it's indeed less intuitive.

But Ctrl++ and Ctrl+- do nothing

I guess you're on laptop? I have issues with those layouts, I can't make it work properly and since it's an Electron issue, I can't fix it myself. 😕

@ahangarha
Copy link
Contributor Author

Today I saw this issue on Sengi. The current font is not complete for Persian and also it looks like a serif font.

image

Wanted to open a new issue but thought maybe it can be related to this issue. If user can specify font in setting (something that is available locally) this issue can be handled. I assume it is not a very big issue to add a text input in setting and set its value as first font for body tag.

@laerm0
Copy link

laerm0 commented Jun 11, 2022

Hi, I know this issue is ooooold...but I don't see a way to activate the zoom feature on macOS.
Screen Shot 2022-06-11 at 14 42 29

Also, no combo of CMD+CTRL+OPT+SHIFT+plus enlarges.

@GrahamDo
Copy link

I see that Ctrl++ and Ctrl+- work on Windows, but you have to use the ones on the numpad. The ones on the number row don't work yet.

@rkiddy
Copy link

rkiddy commented Jan 20, 2023

Where are you seeing the View menus above? It is not (AFAIK) reachable from Settings in the app on Ubuntu. FYI, freshly installed, new user, sorry for newbie-isms. Perhaps we need a "old eyes" tag here. Between the tiny fonts and the really skinny columns, it is giving me a permanent squint... :--)

@NicolasConstant
Copy link
Owner

You can open it with the Alt key, normally. 🙂

@rkiddy
Copy link

rkiddy commented Jan 24, 2023

Wow. I guess I had not bumped into another app that hid its menubar by default. But if that is the usual thing, then now I know that. :--) Much thanx.

@NicolasConstant
Copy link
Owner

It was a request of a linux user at first, it's true you can find this kind of behavior on Firefox for example. It's cleaner so I let it this way, but yes, it's not that common.

@GrahamDo
Copy link

I just want to re-iterate that the CTRL++/CTRL+- thing is just a workaround, not the ultimate solution. As I add more and more columns (either via adding more accounts, or via more issues being resolved that let more things be added as columns), I'm ultimately still going to need a way to control the column widths and font sizes within those columns independently.

I'd like the columns narrower so I can fit more of them on one screen, but the font inside those columns bigger, so I can read their contents without slamming my nose into the monitor.

Just pointing that out. :-)

@ahangarha
Copy link
Contributor Author

⚠️ Sorry for linking to this issue by mistake!

@ahangarha
Copy link
Contributor Author

This issue was made not just for font-size but for font family customization.

@GrahamDo I would recommend opening a new issue for column width adjustment.

@GrahamDo
Copy link

Originally, I did, I think. Nicolas closed it and said it was a duplicate of this one.

Unless I'm thinking of a different issue, I can't remember. I'll check.

@NicolasConstant
Copy link
Owner

We have quite a few issues about column width adjustment, like #373 #460 or #205. I try to keep duplicates as low as possible but I guess those already cover quite some use cases. 🙂

@Lancaban
Copy link

If you are using the desktop app you can increase the scale and the fonts by the same time:

image (hit Alt key to show the toolbar)

Older thread, but I just got Sergi today, wanted to point out that although you can hold alt to access this menu and click on Zoom etc. the Key commands/shortcuts listed next to those items "ctrl++" don't seem to work

@GrahamDo
Copy link

Thanks for pointing that out (and yes, Sengi is great), but I know about it already.

That changes the font size and column width/scaling simultaneously. I need to be able to change the font size independently of the column width and scaling of all the other controls.

@ahangarha
Copy link
Contributor Author

@Lancaban

the Key commands/shortcuts listed next to those items "ctrl++" don't seem to work

I just checked this. It seems it works only with +/- on Numpad!
This needs improvement for sure.

@Lancaban
Copy link

Lancaban commented Jun 2, 2023

I just checked this. It seems it works only with +/- on Numpad!
This needs improvement for sure.

Ahh that explains it!!
I'm using a ten-keyless keyboard!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request request for a new feature
Projects
None yet
Development

No branches or pull requests

8 participants