-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corpus Module Cleanup #19
base: master
Are you sure you want to change the base?
Conversation
Intial Documentation Commit
This one is also broken, let me look at both of them and see if there isn't some meta-pattern we can adopt to facilitate a smoother PR process. I know this is painful for the Travis to be so disagreeable. Also we might consider adopting GitHub Actions in the future, as a better CI/CD system |
Yeah. They both break at the same point. I added some txt and yaml files that some functions depend on. However, it doesn't seem like travis copies those when it installs the package. It's a packaging issue. I've added the paths to Manifest.in like you did for the model but that still doesn't work. I've also tried adding the paths to package_dir and data_files in setup but still, the same thing. |
no problem, working on it now ... will try some things locally, and save tests via pushes to Travis for when I'm fresher in the AM. |
Took sometime to rework the corpus module.
Major changes: