Add shebang support for files using flakes. #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs: https://nixos.org/manual/nix/stable/command-ref/new-cli/nix.html#shebang-interpreter This is slightly more complicated than nix-shell detection due to the `#!nix ...` not appearing directly after the shebang, so re-search-forward is used to find the matching line. This does mean that opening a huge file may slow down emacs while the search is running. There are two mitigations for that: 1. nix-shebang will try to parse the nix-shell line first. 2. Users can keep `nix-shell -i ...` as the second line in your nix script. This won't affect the script at runtime (i.e. it will still use flakes) and keeps the old detection behavior. 3. An option could be added to disable flake support entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs: https://nixos.org/manual/nix/stable/command-ref/new-cli/nix.html#shebang-interpreter
This is slightly more complicated than nix-shell detection due to the
#!nix ...not appearing directly after the shebang, so re-search-forward is used to find the matching line. This does mean that opening a huge file may slow down emacs while the search is running.There are two mitigations for that:
nix-shebang will try to parse the nix-shell line first.
Users can keep
nix-shell -i ...as the second line in your nix script. This won't affect the script at runtime (i.e. it will still use flakes) and keeps the old detection behavior.An option could be added to disable flake support entirely.