Skip to content

Commit

Permalink
derivation-goal: unlock output lock to avoid deadlock
Browse files Browse the repository at this point in the history
guix discovered in their code base. Maybe we should do the same.
  • Loading branch information
Mic92 committed Jan 8, 2025
1 parent 5230d3e commit 3d877ec
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/libstore/build/derivation-goal.cc
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,7 @@ Goal::Co DerivationGoal::tryToBuild()
if (buildMode != bmCheck && allValid) {
debug("skipping build of derivation '%s', someone beat us to it", worker.store.printStorePath(drvPath));
outputLocks.setDeletion(true);
outputLocks.unlock();
co_return done(BuildResult::AlreadyValid, std::move(validOutputs));
}

Expand Down

0 comments on commit 3d877ec

Please sign in to comment.