parsePathFlakeRefWithFragment(): Handle 'path?query' without a fragment #12157
+78
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commands like `nix flake metadata '.?submodules=1'` ignored the query part of the URL, while `nix build '.?submodules=1#foo'` did work correctly because of the presence of the fragment part.
edolstra
added
bug
flakes
backport 2.25-maintenance
github-actions
bot
added
the
with-tests
Mic92
reviewed
Jan 8, 2025
| query = decodeQuery(url.substr(pathEnd + 1, fragmentStart - pathEnd - 1)); | ||
| } | ||
| static std::regex pathFlakeRegex( | ||
| R"(([^?#]*)(\?([^#]*))?(#(.*))?)", |
There was a problem hiding this comment.
Do we have test cases for different urls?
There was a problem hiding this comment.
I've added some unit tests (which revealed another bug).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Commands like
nix flake metadata '.?submodules=1'ignored the query part of the URL, whilenix build '.?submodules=1#foo'did work correctly because of the presence of the fragment part.Before:
After:
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.