nix flake: clarify error message when file is an unknown type #12167
+57
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossComputerGuy
force-pushed
the
fix/unsupported-type-docker
branch
from
992ead7 to
ad7111c
Compare
lucperkins
suggested changes
Jan 10, 2025
src/nix/flake.cc
Outdated
| @@ -941,7 +941,7 @@ struct CmdFlakeInitCommon : virtual Args, EvalCommand | |||
| createSymlink(target, os_string_to_string(PathViewNG { to2 })); | |||
| } | |||
| else | |||
| throw Error("file '%s' has unsupported type", from2); | |||
| throw Error("path '%s' is not either a symlink, file, or directory but a %s", from2, st.typeString()); | |||
There was a problem hiding this comment.
Suggested change
| throw Error("path '%s' is not either a symlink, file, or directory but a %s", from2, st.typeString()); | |
| throw Error("path '%s' needs to be a symlink, file, or directory but instead is a %s", from2, st.typeString()); |
RossComputerGuy
force-pushed
the
fix/unsupported-type-docker
branch
from
ad7111c to
bbf2efc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Clarify the error as seen in #11217
Context
#11217 is where this behavior has been seen
Simply clarifying the error makes the user know why the failure occurred.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.