Make --keep-going work with drv that don't have a system #12168
+60
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossComputerGuy
requested review from
Ericson2314 and
edolstra
as code owners
github-actions
bot
added
with-tests
RossComputerGuy
force-pushed
the
fix/keep-going-not-going
branch
from
3d26e2f to
42567d4
Compare
RossComputerGuy
force-pushed
the
fix/keep-going-not-going
branch
from
42567d4 to
d534b27
Compare
|
The basic idea seems sound here :) |
|
Heh yeah, I'm trying to diagnose why the tests fail. It seems like this PR is cursed with the same problem as the original attempt. |
roberth
reviewed
Jan 10, 2025
| @@ -36,6 +36,7 @@ struct BuildResult | |||
| NotDeterministic, | |||
| ResolvesToAlreadyValid, | |||
| NoSubstituters, | |||
| NoBuilders, | |||
There was a problem hiding this comment.
Suggested change
| NoBuilders, | |
| NoCompatibleBuilder, |
| @@ -61,6 +61,7 @@ MakeError(InvalidPath, Error); | |||
| MakeError(Unsupported, Error); | |||
| MakeError(SubstituteGone, Error); | |||
| MakeError(SubstituterDisabled, Error); | |||
| MakeError(BadSystem, Error); | |||
There was a problem hiding this comment.
Suggested change
| MakeError(BadSystem, Error); | |
| MakeError(NoCompatibleBuilder, Error); |
Comment on lines
+5
to
+10
| # Hack to get the scheduler to do what we want: The `good` derivation can | ||
| # only be built after `delay_good` (which takes a long time to build) while | ||
| # the others don't have any dependency. | ||
| # This means that if we build this with parallelism (`-j2`), then we can be | ||
| # reasonably sure that the failing derivations will be scheduled _before_ the | ||
| # `good` one (and so we can check that `--keep-going` works fine) |
There was a problem hiding this comment.
This could be synchronized by waiting for a file to appear in a mutable directory in extra-sandbox-paths. The test would have to monitor the CLI's log before creating it.
(doing it in the failing derivation would only decrease the length of the race condition, but not make it reliable)
Something along the lines of
nix build --extra-sandbox-paths "$TEST_ROOT/sync" 2>&1 \
| while read ln; do
echo "nix build: $ln"
if echo "$ln" | grepQuiet ...; then
touch "$TEST_ROOT/sync/failing-drv-failed"
fi
done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #8321, this resurrects #8775 and changes things a little differently.
Context
This adds a new build result of
NoBuilderswhich implies that the derivation cannot be build because there are no builders. While a new error failure calledBadSystemis added to imply the system configuration is bad or incompatible. These have similar meaning but imply different things which could make sense for future PR's. Currently, only a bad system error occurs when there are no builders which matches a derivation.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.