Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libstore: fixup unformatted uri when S3 getObject fails (backport #12091) #12180

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 10, 2025

Motivation

Fixes #12090.

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.


Drafted because I want to add a test that catches / validates this.


This is an automatic backport of pull request #12091 done by [Mergify](https://mergify.com).

…error message is properly formatted

(cherry picked from commit 535724f)
…runs faster

Since networking is disabled in these VMs, trying to talk to the default
cache.nixos.org slows the test down (since it can't resolve it).

(cherry picked from commit f0c1262)
@mergify mergify bot requested a review from Ericson2314 as a code owner January 10, 2025 09:48
@mergify mergify bot added the merge-queue label Jan 10, 2025
@mergify mergify bot requested a review from edolstra as a code owner January 10, 2025 09:48
@edolstra edolstra enabled auto-merge January 10, 2025 12:30
@edolstra edolstra merged commit 9a7196c into 2.24-maintenance Jan 10, 2025
25 checks passed
@edolstra edolstra deleted the mergify/bp/2.24-maintenance/pr-12091 branch January 10, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants