[backport 2.3] Separate auth and logic for the daemon #5640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before,
processConnection
wanted to know a user name and user id, andnix-daemon --stdio
, when it isn't proxying to an underlying daemon, would just assume "root" and 0. Butnix-daemon --stdio
(no proxying) shouldn't make guesses about who holds the other end of its standard streams.Now
processConnection
takes an "auth hook", sonix-daemon
can provide the appropriate policy and daemon.cc doesn't need to know or care what it is.(cherry picked from commit 8d4162f)
Depends on #5650
(not actually, but yes in terms of it wouldn't be useful until then.)