-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.spleeter: init at 2.2.2 #133039
base: master
Are you sure you want to change the base?
Conversation
And now dependency |
propagatedBuildInputs = [ scipy ]; | ||
|
||
checkInputs = [ pytestCheckHook ]; | ||
preCheck = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preCheck = '' | |
postPatch = '' |
meta = { | ||
homepage = "https://github.com/deezer/spleeter"; | ||
description = "Audio source separation library including pretrained models"; | ||
license = lib.licenses.mit; | ||
maintainers = with lib.maintainers; [ ris ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta = { | |
homepage = "https://github.com/deezer/spleeter"; | |
description = "Audio source separation library including pretrained models"; | |
license = lib.licenses.mit; | |
maintainers = with lib.maintainers; [ ris ]; | |
meta = with lib; { | |
homepage = "https://github.com/deezer/spleeter"; | |
description = "Audio source separation library including pretrained models"; | |
license = licenses.mit; | |
maintainers = with maintainers; [ ris ]; |
I marked this as stale due to inactivity. → More info |
I rebased this on master here: https://github.com/LennyPenny/nixpkgs/tree/lenny-spleeter I then went ahead and cherry-picked the commits to
Is what I'm getting. This comment mentions manually installing @risicle are you still interested in pursuing this? Otherwise, I'm happy to reach out to the python packaging matrix and get some help in fixing this. |
Motivation for this change
A tensorflow-based audio source separation tool. I've got fairly decent results with it.
The only downside is that it's designed to pull its models down from github on-demand, which means they could be vulnerable to disappearance and it could be unhelpful if a user doesn't have great network access when they need it.
It might be nice to be able to include some of the models along with the package, however:
Note that this does actually download the smallest of the available models, but only as a build-time dependency for the tests.
Includes packaging of dependency
norbert
and also added as an application usingtoPythonApplication
.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)cc @magnetophon through interest in audio tools.