Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanctuary fixes #855

Merged
merged 2 commits into from
Feb 28, 2024
Merged

sanctuary fixes #855

merged 2 commits into from
Feb 28, 2024

Conversation

OmarTawfik
Copy link
Contributor

@OmarTawfik OmarTawfik commented Feb 24, 2024 •
edited
Loading

  • reset git state before running tests
  • fix a bunch of nits with string/error reporting in CI
  • trim null terminators from input files

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3bf29f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik OmarTawfik marked this pull request as ready for review February 26, 2024 16:58
@OmarTawfik OmarTawfik requested a review from a team as a code owner February 26, 2024 16:58
@OmarTawfik OmarTawfik enabled auto-merge February 26, 2024 16:58
@OmarTawfik OmarTawfik mentioned this pull request Feb 26, 2024
Closed
Xanewok
Xanewok reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@Xanewok Xanewok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great to have more context and reason behind these changes 🙏

crates/solidity/testing/sanctuary/src/tests.rs Outdated Show resolved Hide resolved
crates/solidity/testing/sanctuary/src/reporting.rs Outdated Show resolved Hide resolved
crates/solidity/testing/sanctuary/src/datasets.rs Show resolved Hide resolved
@OmarTawfik
sanctuary fixes
571632f 
- reset git state before running tests
- fix a bunch of nits with string/error reporting in CI
- trim null terminators from input files
@OmarTawfik
Copy link
Contributor Author

It'd be great to have more context and reason behind these changes 🙏

@Xanewok apologies. I added it to the commit message, but for some reason, it wasn't copied to the PR. Added!

Xanewok
Xanewok approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@Xanewok Xanewok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments and the links, these are helpful!

@OmarTawfik OmarTawfik added this pull request to the merge queue Feb 28, 2024
Merged via the queue into NomicFoundation:main with commit 67d9dc5 Feb 28, 2024
1 check passed
@OmarTawfik OmarTawfik deleted the sanctuary-fixes branch February 28, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xanewok Xanewok Xanewok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarTawfik @Xanewok