Allow log flushing to fail in nat-lab (#937)

NordSecurity · Nov 11, 2024 · f4920a9 · f4920a9
1 parent 6f38aea
commit f4920a9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/.unreleased/allow_log_flush_to_fail_during_test_cleanup b/.unreleased/allow_log_flush_to_fail_during_test_cleanup
diff --git a/nat-lab/tests/telio.py b/nat-lab/tests/telio.py
@@ -472,7 +472,16 @@ async def on_stderr(stderr: str) -> None:
 
                 print(datetime.now(), "Test cleanup: Shutting down")
                 if self._libtelio_proxy:
-                    await self.get_proxy().flush_logs()
+                    # flush_logs() is allowed to fail here:
+                    try:
+                        await self.get_proxy().flush_logs()
+                    # Since this is clean up code, catching general exceptions is fine:
+                    except Exception as e:  # pylint: disable=broad-exception-caught
+                        print(
+                            datetime.now(),
+                            f"Test cleanup: Exception while flushing logs: {e}",
+                        )
+
                     await self.get_proxy().shutdown(self._connection.target_name())
                 else:
                     print(