-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLT-5831] QNAP: move cgi logic to teliod #1012
Conversation
4d75c96
to
03917df
Compare
03917df
to
38938fe
Compare
Can we use instead something like https://docs.rs/cgi2/latest/cgi/ or https://docs.rs/cgi/0.6.0/cgi/ , so that we avoid implementing irrelevant details of cgi/http, and focus on our business logic? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imho looks strange, like someone wanted to write a shell script, but had to do it in rust for some reason
@stalowyjez that was more or less what happened, but what do you think it looks strange besides other comments? |
@tomaszklak thanks for the recommendations, will take a look! |
I mean it just doesn't look like a right tool for the job to me |
38938fe
to
0abc522
Compare
0abc522
to
687836b
Compare
687836b
to
a21cb40
Compare
a21cb40
to
4cd24a8
Compare
4cd24a8
to
2608ac7
Compare
2608ac7
to
5f8d630
Compare
5f8d630
to
2657c32
Compare
Original work done in #1012. This is restructure and reabase on common base.
Original work done in #1012. This is restructure and reabase on common base.
97e2acd
to
a696f1e
Compare
a696f1e
to
e58d335
Compare
e58d335
to
bf4f507
Compare
bf4f507
to
ab80e4b
Compare
ab80e4b
to
39fd537
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1.0
Problem
CGI consists in a bash script that handles http requests and directly control teliod daemon execution.
As in the near future more features (eg: authentication) are to be added, after internal discussions it was decided that would be more secure and easy to maintain/implement if the handling of the requests is moved to the teliod binary.
Solution
Make the CGI script redirect http requests to teliod.
☑️ Definition of Done checklist