Refactor batcher and inline into SessionKeeper #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPukenis
force-pushed
the
LLT-5857_refactor_batcher
branch
from
3678fc7 to
002eaa4
Compare
LukasPukenis
temporarily deployed
to
Internal
GitHub Actions
Inactive
LukasPukenis
force-pushed
the
LLT-5857_refactor_batcher
branch
from
002eaa4 to
b3979cf
Compare
LukasPukenis
temporarily deployed
to
Internal
GitHub Actions
Inactive
LukasPukenis
force-pushed
the
LLT-5857_refactor_batcher
branch
from
b3979cf to
5e49bb5
Compare
LukasPukenis
temporarily deployed
to
Internal
GitHub Actions
Inactive
LukasPukenis
force-pushed
the
LLT-5857_refactor_batcher
branch
from
5e49bb5 to
2d34b68
Compare
LukasPukenis
temporarily deployed
to
Internal
GitHub Actions
Inactive
LukasPukenis
force-pushed
the
LLT-5857_refactor_batcher
branch
from
2d34b68 to
b73a4ea
Compare
LukasPukenis
temporarily deployed
to
Internal
GitHub Actions
Inactive
LukasPukenis
force-pushed
the
LLT-5857_refactor_batcher
branch
from
b73a4ea to
c61628a
Compare
LukasPukenis
temporarily deployed
to
Internal
GitHub Actions
Inactive
LukasPukenis
force-pushed
the
LLT-5857_refactor_batcher
branch
from
c61628a to
03ce6e3
Compare
LukasPukenis
temporarily deployed
to
Internal
GitHub Actions
Inactive
jjanowsk
reviewed
Dec 20, 2024
This commit does these things: - Inlines batching flag to SessionKeeper, removing batcher entirely as a separate entity with all of its logic(threshold, traffic trigger). - Emits all actions from SessionKeeper if batching is enabled when an action is added. This works nicely if we can guarantee that actions are gonna be a multiple of some T which is the case as currently we target T=70s for proxy, direct, vpn, stun keepalives. This also makes thresholds and the whole logic around them irrelevant. Traffic triggered batching implementation was doing more harm than good since it triggers on _any_ traffic, meaning even when alignment was achieved, it might misalign since any traffic triggers it. Feature flags are not removed in this commit so not to push for version update of libtelio, so now they are no-op. Signed-off-by: Lukas Pukenis <[email protected]> Signed-off-by: Lukas Pukenis <[email protected]>
LukasPukenis
force-pushed
the
LLT-5857_refactor_batcher
branch
from
03ce6e3 to
613ca6a
Compare
LukasPukenis
temporarily deployed
to
Internal
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
--describe problem being solved--
Solution
--describe selected solution--
☑️ Definition of Done checklist