Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLT-5882: Refactor teliod cgi structure #1047

Merged
merged 6 commits into from
Jan 8, 2025
Merged

LLT-5882: Refactor teliod cgi structure #1047

merged 6 commits into from
Jan 8, 2025

Conversation

lcruz99
Copy link
Contributor

@lcruz99 lcruz99 commented Dec 23, 2024 •
edited
Loading

This PR refactors the teliod CGI component, changing the structure focus to be the CGI feature instead of QNAP.

Main changes:

  • Makes QNAP feature a subset of CGI feature.
  • Use URI route as endpoints instead of query strings.
  • Adds test CGI server to Justfile
  • Directory tree structure
  • Removes PID file usage
  • Trace logs added to every http response (debug builds only).

☑️ Definition of Done checklist

  • Commit history is clean (requirements)
  • README.md is updated
  • Functionality is covered by unit or integration tests

@lcruz99 lcruz99 force-pushed the LLT-5882_refactor_teliod_cgi_structure branch from e4cd113 to a76fed0 Compare December 30, 2024 15:33
@lcruz99 lcruz99 force-pushed the LLT-5882_refactor_teliod_cgi_structure branch from a76fed0 to 9f8b4f9 Compare January 2, 2025 13:00
@lcruz99 lcruz99 force-pushed the LLT-5882_refactor_teliod_cgi_structure branch from 9f8b4f9 to f020572 Compare January 2, 2025 13:02
@lcruz99 lcruz99 marked this pull request as ready for review January 2, 2025 13:09
@lcruz99 lcruz99 requested a review from a team as a code owner January 2, 2025 13:09
@lcruz99 lcruz99 force-pushed the LLT-5882_refactor_teliod_cgi_structure branch from f020572 to d3a03f0 Compare January 2, 2025 15:18
packgron
packgron reviewed Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@packgron packgron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.0 Nice cleanup, one minor nitpick

clis/teliod/Cargo.toml Outdated Show resolved Hide resolved
This was referenced Jan 7, 2025
Closed
Closed
@lcruz99 lcruz99 force-pushed the LLT-5882_refactor_teliod_cgi_structure branch from d3a03f0 to d558afa Compare January 7, 2025 16:52
@lcruz99 lcruz99 mentioned this pull request Jan 7, 2025
Open
3 tasks
gytsto
gytsto approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@gytsto gytsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lcruz99 lcruz99 force-pushed the LLT-5882_refactor_teliod_cgi_structure branch from d558afa to 7ee792d Compare January 8, 2025 12:01
@lcruz99 lcruz99 enabled auto-merge January 8, 2025 12:01
stalowyjez
stalowyjez reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@stalowyjez stalowyjez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this one old thing. I really like the split of this PR into the commits ;)

clis/teliod/src/cgi/constants.rs Show resolved Hide resolved
@lcruz99 lcruz99 merged commit c3b53b0 into main Jan 8, 2025
64 checks passed
@lcruz99 lcruz99 deleted the LLT-5882_refactor_teliod_cgi_structure branch January 8, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stalowyjez stalowyjez stalowyjez left review comments

@packgron packgron packgron left review comments

@gytsto gytsto gytsto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lcruz99 @packgron @stalowyjez @gytsto