Fix cargo doc on mac and add a test for it #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should now work on a macos host: $ cargo +nightly-2024-01-25 doc --features tokio/test-util --workspace --no-deps --document-private-items --lib --all-features --target-dir=public --exclude telio-lana --open
tomaszklak
requested review from
Jauler,
jjanowsk,
packgron and
a team
as code owners
tomaszklak
force-pushed
the
LLT-5075-fix-cargo-doc-on-mac
branch
from
16c10bc to
e9300fb
Compare
|
Looks good to me, but just as a sanity check, run the action https://github.com/NordSecurity/libtelio/actions/workflows/gh-pages.yml to publish the pages. If it all works I'll happily approve the PR |
mathiaspeters
approved these changes
May 28, 2024
packgron
pushed a commit
that referenced
this pull request
Jun 4, 2024
Fix cargo doc on mac and add a test for it
jjanowsk
pushed a commit
that referenced
this pull request
Jun 4, 2024
Fix cargo doc on mac and add a test for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cargo doc was not working previously on a macos host.
Solution
Don't use linux only code on macos. Also automated job is added to not break it in future by accident.
☑️ Definition of Done checklist