[14.0][PERF] account_invoice_refund_link: translate post_init_hook into SQL #1875
+46
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ricardoalso
force-pushed
the
account_invoice_refund_link_pre_init_hook
branch
from
a9a0826 to
a251218
Compare
Cache invalidation is required after writing origin_line_id in refund invoice lines in SQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key changes include replacing the Python logic with a SQL query to handle the matching process more efficiently.
With a large database ( > 65 million account.move.line records) I faced a memory error when executing the post_init_hook.
By translating the python code to a SQL query it took me less than 10 minutes to execute it (postgresql V16.0)