Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] account_mass_reconcile : fix write-off with today's date #552

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[16.0][FIX] account_mass_reconcile : fix write-off with today's date #552

merged 1 commit into from
Oct 31, 2023

Conversation

florian-dacosta
Copy link
Contributor

No description provided.

@florian-dacosta
Copy link
Contributor Author

Hello @AaronHForgeFlow @ljsalvatierra-factorlibre

Seeing you are working with account_mass_reconcile module, would you mind doing a review here ?
It fixes the actual/today write off date mode.
Also, display an error message when trying to check the history of an empty reconciliation run. I did it because else it was displaying a traceback error.

ljsalvatierra-factorlibre
ljsalvatierra-factorlibre suggested changes Oct 25, 2023
View reviewed changes
account_mass_reconcile/models/mass_reconcile_history.py Outdated
Comment on lines 55 to 56
if not move_line_ids:
raise exceptions.UserError(_("No Reconciled items this time."))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't rise an exception.

@AaronHForgeFlow
Copy link

Ok for the fallback value on the date of the write-off. I am not sure about showing a message when there is no reconciled items. If the list is empty, it means there are no reconciled items, that is correct I think.

@florian-dacosta florian-dacosta force-pushed the 16-fix-mass-reconcile-today branch from fb0cbca to c7f58b2 Compare October 25, 2023 12:33
@florian-dacosta
Copy link
Contributor Author

@AaronHForgeFlow @ljsalvatierra-factorlibre Well... I guess you are right. I can't remember nor reproduce the issue I had with the empty reconciled items list.

I just removed this part, only fixing the reconciliation with write off at today's date here.
If I run in the other issue, I'll make a dedicated PR with a way to reproduce it on runbot.

Thanks for the reviews

@florian-dacosta florian-dacosta changed the title [16.0][FIX] account_mass_reconcile : fix write-off with today's date and history button when no history [16.0][FIX] account_mass_reconcile : fix write-off with today's date Oct 25, 2023
@florian-dacosta florian-dacosta force-pushed the 16-fix-mass-reconcile-today branch 2 times, most recently from 792cbde to 9eab202 Compare October 25, 2023 17:25
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@florian-dacosta florian-dacosta force-pushed the 16-fix-mass-reconcile-today branch from 9eab202 to ce5b57e Compare October 31, 2023 09:33
@AaronHForgeFlow
Copy link

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-552-by-AaronHForgeFlow-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 48300b8 into OCA:16.0 Oct 31, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6f5b543. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljsalvatierra-factorlibre ljsalvatierra-factorlibre ljsalvatierra-factorlibre approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@bguillot bguillot bguillot approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@florian-dacosta @AaronHForgeFlow @OCA-git-bot @bguillot @ljsalvatierra-factorlibre