[16.0][FIX] account_reconcile_oca: Add context key skip_account_move_synchronization to avoid side effects

[victoralmau]

Add context key skip_account_move_synchronization to avoid side effects

We need to define skip_account_move_synchronization in the context to avoid that when writing the bank statement line, some values can be updated in the account.move.line making the information inconsistent.

Related to #779

Fixes #779

@Tecnativa TT52634

[OCA-git-bot]

Hi @etobella,
some modules you are maintaining are being modified, check this out!

[pedrobaeza]

/ocabot merge patch

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-782-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at f89f25a. Thanks a lot for contributing to OCA. ❤️

[florian-dacosta]

Hello,

I appreciate a fix regarding this issue. Although, this PR could have been left open a bit more time no?
I am not as confident as you seem to be about this one.

In some case, the account move synchronisation is necessary, no ? If the field "amount", or "amount_currency" is updated for instance, an update should be made right ?

Are you sure it is fine and can you explain why please ?

[victoralmau]

I am not sure if anything should be changed in any case, anyway, if you are clear about any case explain it in an issue, suggest the appropriate solution (only for that specific use case) and add a test to confirm that the use case works.

[florian-dacosta]

I am not sure if anything should be changed in any case

Sorry, I did not get what you mean?

I just did some test with this PR merged, and there is issues with what I was saying.
Example :

1. install module with demo data
2. Create a journal in a foreign currency (like euro)
3. Create a statement line for 1000 euros in this journal
4. Now, from dashboard, click on reconcile => Switch to list view => edit the amount on the previously created line and set 2000.
5. Switch back to kanban view and you can see the amount currency is 2000 euros but the credit/debit did not change.
   Also the related accounting entries did not update

Other case

1. From dashboard, click on reconcile

2. select a line : change its partner (by clicking on the liquidity line / manual operation tab)
   

3. Change the account of the suspense line and then validate
   

The resulting accounting entries are wrong, the partner is not set :