l10n_cn_account_voucher: add a new way to generate chinese voucher number #18
Conversation
…cher depends on l10n_cn_account_voucher
…ucher depends on l10n_cn_account_voucher, how to generate chinese voucher number is optional
… voucher number manually, much more flex.
|
@Rona111 @elicoidal read l10n_cn_sequence_voucher, nice work but didn't fit in my shoe, so create another module which a litte manually but handy, My customer usually need print voucher at the end of the month or beginning of another month, by that time the voucher generated maybe be been closed an open, deleted and created many times, generate chinese voucher number automaticly maybe not the best choice here, when to print, when to determine is my goal. |
|
and reverse the depends help separate behivair and print module, but the best way maybe create a new module to put custom fields in that, but so far is good to me |
| @@ -0,0 +1,2 @@ | |||
| # __author__ = [email protected] | |||
There was a problem hiding this comment.
@cysnake4713 Thanks for your contribution to the OCA.
Please create one pull request per module (the other modules besides are already included in another PR.
Besides, please let me introduce to you some basic information about contribution in OCA and I will review other points in more comments inside the code..
In general, please follow the principles:
- Contribution guidelines: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md
- you need to make sure the code is PEP8 compliant for example and create a README file
- Please follow the OCA README template:
https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst - We recommend to include a screenshot as well to help new comers (nice to have)
- Please use simple headers in all py files following OCA templates
https://github.com/OCA/maintainer-tools/blob/master/template/module/__openerp__.py#L3 - Please sort all imports in alphabetical order following: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#imports
There was a problem hiding this comment.
Please create one pull request per module (the other modules besides are already included in another PR.
three of the module has depends, pull them seperatly will not pass runbot test. I will add a link to the old pr if that's ok
#8
There was a problem hiding this comment.
The logical order is to have the first PR #8 merged before moving forward with yours.
|
this pr is based on #8 |
|
@elicoidal base on you comment updated the file, please check if python file format and english translation is ok, then I will rebase the commit and update zh_CN.po file to make offical PR, |
|
I would suggest to first validate and merge PR#8, rebase this one and finish the process with your module. |
| <t t-foreach='docs' t-as='o' > | ||
| <t t-call="report.internal_layout"> | ||
| <t t-set="body"> | ||
| <t t-foreach='docs' t-as='o'> |
There was a problem hiding this comment.
voucher seems use minimal layout to print is much nice. internal_layout has header div, which seems not be need in voucher
There was a problem hiding this comment.
I tend to agree with you.
Do you have a screenshot of both cases?
No description provided.