[14.0][IMP] purchase_sale_inter_company: the sale order is updated when the purchase order is modified #391

chafique-delli · 2022-10-14T11:00:45Z

Features added to the module:
If an inter-company purchase order is validated, its modification is prevented.
If you want to modify a purchase order, you have to cancel it first, then put it back in draft so that you can modify it and finally revalidate it.
When you revalidate the purchase order after modification, it canceled the sales order and recreates one.

chafique-delli · 2022-10-14T12:15:11Z

@sebastienbeau

purchase_sale_inter_company/models/purchase_order.py

chafique-delli · 2023-01-16T10:16:11Z

up @sebastienbeau

francesco-ooops · 2023-01-16T10:22:24Z

@chafique-delli can you rebase in order to trigger runbot rebild?

chafique-delli · 2023-01-24T14:56:50Z

@chafique-delli can you rebase in order to trigger runbot rebild?

@francesco-ooops , it's done.

elvise · 2023-05-23T10:41:39Z

@chafique-delli can you rebase ?

github-actions · 2023-09-24T12:14:27Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

francesco-ooops · 2023-09-25T08:17:38Z

@chafique-delli did you implement this successfully in the end?

sebastienbeau · 2023-10-15T15:36:54Z

purchase_sale_inter_company/models/purchase_order.py

+            "cancel",
+        ]:
+            force_number = self.intercompany_sale_id.name
+            self.intercompany_sale_id.with_context(force_delete=True).unlink()


I am not sure about this.
If a sale order already have a picking and you cancel it. I pretty sure you can not delete the sale.

Maybe we should add a try except and if we can unlink it, we can keep the same number. If not we should use a new number as sale name should be uniq

purchase_sale_inter_company/models/purchase_order.py

aleuffre

Some minor issues from code review.

Most importantly, from a functional POV: I agree with canceling the SO if the PO is canceled. I'm not so sure about having a new SO with the same name if the PO is then re-confirmed. It could be misleading if the PO has changed, but the user on the SO side thinks they're looking at the same one as before.

In general, also, I'm against deleting things (as opposed to canceling/archiving). Preserving the history of what happened is important. There can be attachments, comments, or edits on the SO that would suddenly be deleted as well. If there's no issue with making a new SO, I would make a new SO instead.

aleuffre · 2023-12-11T11:35:07Z

purchase_sale_inter_company/models/purchase_order.py

+        if self.intercompany_sale_id:
+            if self.intercompany_sale_id.state not in ["draft", "sent", "cancel"]:
+                raise UserError(
+                    _(
+                        "You can not cancel your purchase order %s.\n"
+                        "The sale order %s at your supplier %s that is linked "
+                        "to your purchase order, is in the state %s.\n"
+                        "In order to cancel your purchase order, you must first "
+                        "ask your supplier to cancel his sale order."
+                    )
+                    % (
+                        self.name,
+                        self.intercompany_sale_id.name,
+                        self.partner_id.name,
+                        self.intercompany_sale_id.state,
+                    )
+                )
+            self.intercompany_sale_id.sudo().action_cancel()
+            self.write({"partner_ref": False})


question: do you not need sudo to read these fields self.intercompany_sale.id.state, self.intercompany_sale_id.name ?

Indeed, I think we need the sudo here.

@Kev-Roche , it's fixed.

aleuffre · 2023-12-11T11:35:50Z

purchase_sale_inter_company/models/purchase_order.py

+        if self.intercompany_sale_id:
+            if self.intercompany_sale_id.state not in ["draft", "sent", "cancel"]:
+                raise UserError(
+                    _(
+                        "You can not cancel your purchase order %s.\n"
+                        "The sale order %s at your supplier %s that is linked "
+                        "to your purchase order, is in the state %s.\n"
+                        "In order to cancel your purchase order, you must first "
+                        "ask your supplier to cancel his sale order."
+                    )
+                    % (
+                        self.name,
+                        self.intercompany_sale_id.name,
+                        self.partner_id.name,
+                        self.intercompany_sale_id.state,
+                    )
+                )
+            self.intercompany_sale_id.sudo().action_cancel()
+            self.write({"partner_ref": False})


question: why delete the partner_ref? The PO is still the same even if it was cancelled

aleuffre · 2023-12-11T11:46:27Z

purchase_sale_inter_company/views/purchase_view.xml

+            </field>
+            <field name="order_line" position="attributes">
+                <attribute name="attrs" operation="python_dict" key="readonly">
+                    ['|', ('state', 'in', ('done', 'cancel')), ('intercompany_sale_id', '!=', False), ('state', '=', 'purchase')]


issue: I'm not 100% sure about the order of operations, so, for readability if nothing else, I'd change this to:

Suggested change

['|', ('state', 'in', ('done', 'cancel')), ('intercompany_sale_id', '!=', False), ('state', '=', 'purchase')]

['|',

('state', 'in', ('done', 'cancel')),

' '

('intercompany_sale_id', '!=', False),

('state', '=', 'purchase')]

Translated: Always make it readonly during states done and cancel. If there is an intercompany_sale_id, make it readonly during purchase as well.

francesco-ooops · 2024-02-01T09:39:12Z

@chafique-delli do you plan on working further on this one?

chafique-delli · 2024-02-23T09:13:52Z

do you plan on working further on this one

Yes, from March, I will have more time to think about the logic of canceling the PO as suggested by @aleuffre

…en the purchase order is modified

francesco-ooops · 2024-03-28T10:01:03Z

@chafique-delli let us know when ready for review :)

github-actions · 2024-07-28T12:17:24Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

francesco-ooops · 2024-08-26T08:34:58Z

@chafique-delli do you think this will be completed eventually?

github-actions · 2025-01-05T12:20:05Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

sebastienbeau reviewed Nov 7, 2022

View reviewed changes

purchase_sale_inter_company/models/purchase_order.py Outdated Show resolved Hide resolved

sebastienbeau force-pushed the 14.0-IMP-purchase_sale_inter_company branch from dea300d to f41bfd3 Compare November 28, 2022 12:47

chafique-delli force-pushed the 14.0-IMP-purchase_sale_inter_company branch from f41bfd3 to 96c0a54 Compare January 24, 2023 14:48

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 24, 2023

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 1, 2023

chafique-delli force-pushed the 14.0-IMP-purchase_sale_inter_company branch from 96c0a54 to 3f3ebd4 Compare October 10, 2023 15:38

sebastienbeau force-pushed the 14.0-IMP-purchase_sale_inter_company branch from 3f3ebd4 to e8566bd Compare October 15, 2023 14:55

sebastienbeau approved these changes Oct 15, 2023 •

edited

Loading

View reviewed changes

sebastienbeau reviewed Oct 15, 2023

View reviewed changes

sebastienbeau requested changes Oct 15, 2023

View reviewed changes

purchase_sale_inter_company/models/purchase_order.py Outdated Show resolved Hide resolved

sebastienbeau force-pushed the 14.0-IMP-purchase_sale_inter_company branch from e8566bd to 9b0a353 Compare October 15, 2023 16:58

sebastienbeau force-pushed the 14.0-IMP-purchase_sale_inter_company branch from 9b0a353 to ac1b9cc Compare December 7, 2023 23:36

aleuffre reviewed Dec 11, 2023

View reviewed changes

legalsylvain added the needs fixing label Dec 16, 2023

legalsylvain added this to the 14.0 milestone Dec 17, 2023

chafique-delli force-pushed the 14.0-IMP-purchase_sale_inter_company branch 3 times, most recently from e02e7ff to df1dbd8 Compare March 26, 2024 08:51

[14.0][IMP] purchase_sale_inter_company: the sale order is updated wh…

a3568be

…en the purchase order is modified

chafique-delli force-pushed the 14.0-IMP-purchase_sale_inter_company branch from df1dbd8 to a3568be Compare March 26, 2024 12:30

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 28, 2024

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 1, 2024

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][IMP] purchase_sale_inter_company: the sale order is updated when the purchase order is modified #391

[14.0][IMP] purchase_sale_inter_company: the sale order is updated when the purchase order is modified #391

chafique-delli commented Oct 14, 2022 •

edited

Loading

chafique-delli commented Oct 14, 2022

chafique-delli commented Jan 16, 2023

francesco-ooops commented Jan 16, 2023

chafique-delli commented Jan 24, 2023

elvise commented May 23, 2023

github-actions bot commented Sep 24, 2023

francesco-ooops commented Sep 25, 2023

sebastienbeau Oct 15, 2023

aleuffre left a comment •

edited

Loading

aleuffre Dec 11, 2023

Kev-Roche Mar 24, 2024

chafique-delli Mar 26, 2024

aleuffre Dec 11, 2023

aleuffre Dec 11, 2023 •

edited

Loading

francesco-ooops commented Feb 1, 2024

chafique-delli commented Feb 23, 2024

francesco-ooops commented Mar 28, 2024

github-actions bot commented Jul 28, 2024

francesco-ooops commented Aug 26, 2024

github-actions bot commented Jan 5, 2025

[14.0][IMP] purchase_sale_inter_company: the sale order is updated when the purchase order is modified #391

Are you sure you want to change the base?

[14.0][IMP] purchase_sale_inter_company: the sale order is updated when the purchase order is modified #391

Conversation

chafique-delli commented Oct 14, 2022 • edited Loading

chafique-delli commented Oct 14, 2022

chafique-delli commented Jan 16, 2023

francesco-ooops commented Jan 16, 2023

chafique-delli commented Jan 24, 2023

elvise commented May 23, 2023

github-actions bot commented Sep 24, 2023

francesco-ooops commented Sep 25, 2023

sebastienbeau Oct 15, 2023

Choose a reason for hiding this comment

aleuffre left a comment • edited Loading

Choose a reason for hiding this comment

aleuffre Dec 11, 2023

Choose a reason for hiding this comment

Kev-Roche Mar 24, 2024

Choose a reason for hiding this comment

chafique-delli Mar 26, 2024

Choose a reason for hiding this comment

aleuffre Dec 11, 2023

Choose a reason for hiding this comment

aleuffre Dec 11, 2023 • edited Loading

Choose a reason for hiding this comment

francesco-ooops commented Feb 1, 2024

chafique-delli commented Feb 23, 2024

francesco-ooops commented Mar 28, 2024

github-actions bot commented Jul 28, 2024

francesco-ooops commented Aug 26, 2024

github-actions bot commented Jan 5, 2025

chafique-delli commented Oct 14, 2022 •

edited

Loading

aleuffre left a comment •

edited

Loading

aleuffre Dec 11, 2023 •

edited

Loading