Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] utm_source_multi_company: Migration to 15.0 #518

Merged
merged 7 commits into from
May 18, 2024
Merged

[MIG] utm_source_multi_company: Migration to 15.0 #518

merged 7 commits into from
May 18, 2024

Conversation

amh-mw
Copy link

@amh-mw amh-mw commented Oct 10, 2023

No description provided.

@amh-mw amh-mw mentioned this pull request Oct 10, 2023
Open
17 tasks
@legalsylvain
Copy link
Contributor

/ocabot migration utm_source_multi_company

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Dec 17, 2023
legalsylvain
legalsylvain reviewed Dec 17, 2023
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amh-mw. Thanks for porting this module.
a comment inline. Otherwise, LGTM. .

Thanks !

utm_source_multi_company/security/utm_source.xml Show resolved Hide resolved
legalsylvain
legalsylvain approved these changes Dec 17, 2023
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff review. LGTM.

@amh-mw
Copy link
Author

amh-mw commented Apr 30, 2024

@OCA/intercompany-maintainers Merge?

@legalsylvain
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-518-by-legalsylvain-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 30, 2024
@OCA-git-bot
Merge PR #518 into 15.0
76a4b8f 
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-518-by-legalsylvain-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@dreispt
Copy link
Member

dreispt commented May 18, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-518-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 641c7d9 into OCA:15.0 May 18, 2024
4 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7aa9e08. Thanks a lot for contributing to OCA. ❤️

@amh-mw amh-mw deleted the 15.0-mig-utm_source_multi_company branch May 21, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@legalsylvain legalsylvain legalsylvain approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
7 participants
@amh-mw @legalsylvain @OCA-git-bot @dreispt @marcelsavegnago @sbejaoui @oca-travis