Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] purchase_sale_stock_inter_company : partial deliver drop shipping #742

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[FIX] purchase_sale_stock_inter_company : partial deliver drop shipping #742

wants to merge 1 commit into from

Conversation

metaminux
Copy link
Contributor

Fixes #741

@metaminux
Copy link
Contributor Author

Hi @OCA/intercompany-maintainers

This PR is related to #741

I want to fix a behaviour in purchase_sale_stock_inter_company that only occurs when stock_dropshipping is installed, but stock_dropshipping is not in the dependencies...

I wrote a test, but it is failing early because dropshipping route is not found in the system, making it irrelevant.

What would be the best approach here ?

@metaminux
Copy link
Contributor Author

@Kev-Roche @emiliesoutiras @chafique-delli FYI

@metaminux
Copy link
Contributor Author

Hi @OCA/intercompany-maintainers

This PR is related to #741

I want to fix a behaviour in purchase_sale_stock_inter_company that only occurs when stock_dropshipping is installed, but stock_dropshipping is not in the dependencies...

I wrote a test, but it is failing early because dropshipping route is not found in the system, making it irrelevant.

What would be the best approach here ?

Looking at odoo/odoo#40188 it seems creating an other module is the way to go...

@metaminux metaminux force-pushed the 16.0-fix_purchase_sale_stock_inter_company_dropshipping branch from 9d64d4a to e6ffa23 Compare December 18, 2024 15:32
@metaminux
[ADD] test_purchase_sale_stock_dropshipping_inter_company : new modul…
b85f94b 
…e for tests

Add tests for purchase_sale_stock_dropshipping_inter_company when drop shipping is installed
Refactor purchase_sale_inter_company to allow inheritance
@metaminux metaminux force-pushed the 16.0-fix_purchase_sale_stock_inter_company_dropshipping branch from e6ffa23 to b85f94b Compare December 18, 2024 18:05
@metaminux
Copy link
Contributor Author

New module test_purchase_sale_stock_dropshipping_inter_company created

I had to "cherry-pick" some changes from 14.0 to avoid conflicts with partner_multi_company :

Now tests are failing as described in #741
See https://github.com/OCA/multi-company/actions/runs/12398725454/job/34612085890?pr=742#step:8:1203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@metaminux