-
-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][FIX] report_xlsx: Preserve custom context by using context from report instead of user context #933
base: 17.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM.
I think you should adjust the commit msg to include the module name. Maybe "[FIX] report_xlsx: preserve custom context by using context from report instead of user context"
6ebff58
to
063742f
Compare
Thank you. I did the update. |
…rt instead of user context
063742f
to
946537f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Code review.
Steps to Reproduce:
Observer Behavior
Currently, when trying to send the context through the xlsx report action, the context is always replaced by the default context of Odoo. Hence, the report cannot render data dynamically based on the context when calling report action.
Expected Behavior
The context of action report should be taken into account instead of context(this will include env.services.user.context) of env.services.user.context.