[15.0][IMP] sale_report_delivered: Add partner salesperson to sales report from delivery orders #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sergio-teruel, |
pilarvargas-tecnativa
force-pushed
the
15.0-imp-sale_report_delivered
branch
from
bbae6c2 to
87838a8
Compare
sergio-teruel
suggested changes
Nov 29, 2024
| @@ -51,6 +51,7 @@ | |||
| domain="[('state','not in',('draft', 'cancel', 'sent'))]" | |||
| /> | |||
| <separator /> | |||
| <field name="user_from_partner_id" /> | |||
There was a problem hiding this comment.
Please, can you put the new field after the user_id?
Users are used to having that field first.
…from delivery orders TT51908
pilarvargas-tecnativa
force-pushed
the
15.0-imp-sale_report_delivered
branch
from
87838a8 to
61764d6
Compare
carlosdauden
approved these changes
Nov 29, 2024
sergio-teruel
approved these changes
Nov 29, 2024
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 310dc89. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT51908
@sergio-teruel @carlosdauden please review