-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] stock_quant_task_deferred #2205
base: 16.0
Are you sure you want to change the base?
[16.0][ADD] stock_quant_task_deferred #2205
Conversation
Cc @sebalix |
f75969f
to
2c47b58
Compare
7dc2c37
to
e126ec8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: why not using stock.skip_quant_tasks
config parameter? (I guess there is a reason)
To not pollute the list of quants for users, we also added a default filter to display only those having quantity != 0. Should it be part of this module as well?
@@ -0,0 +1,2 @@ | |||
- Denis Roussel <[email protected]> | |||
- Jacques-Étienne Baudoux <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I should be listed as well? As I gave the idea to J-E (I implemented that for one of our customer).
EDIT: if not I don't really care, happy to see this consolidated in a module :)
I hesitated about that, but could be a good idea |
@jbaudoux @grindtildeath @simahawk