Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] stock_location_lockdown: Migration to 18.0. #2209

Open
wants to merge 43 commits into
base: 18.0
Choose a base branch
from

Conversation

ced-adhoc
Copy link
Contributor

No description provided.

florian-dacosta and others added 30 commits December 2, 2024 08:15
When forcing an outgoing move and then moving it. Odoo create a
negative quant. This quant should not be in the locked location
because no quand will go in it and so the negative quant will stay
here for ever
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-10.0/stock-logistics-warehouse-10.0-stock_location_lockdown
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-10-0/stock-logistics-warehouse-10-0-stock_location_lockdown/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_location_lockdown
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_location_lockdown/
weblate and others added 12 commits December 2, 2024 08:15
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_location_lockdown
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_location_lockdown/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_location_lockdown
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_location_lockdown/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-17.0/stock-logistics-warehouse-17.0-stock_location_lockdown
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-17-0/stock-logistics-warehouse-17-0-stock_location_lockdown/
Currently translated at 100.0% (6 of 6 strings)

Translation: stock-logistics-warehouse-17.0/stock-logistics-warehouse-17.0-stock_location_lockdown
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-17-0/stock-logistics-warehouse-17-0-stock_location_lockdown/es/
@ced-adhoc ced-adhoc mentioned this pull request Dec 2, 2024
23 tasks
@ced-adhoc ced-adhoc force-pushed the 18.0-mig-stock_location_lockdown branch from 45894d7 to aaf775d Compare December 3, 2024 14:05
Copy link

@luc-adhoc luc-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional review

@rousseldenis
Copy link
Contributor

/ocabot migration stock_location_lockdown

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Dec 4, 2024
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ced-adhoc
Copy link
Contributor Author

Hi @rousseldenis could you please check this? Thanks!

@ced-adhoc
Copy link
Contributor Author

Hi @rousseldenis , could you please check this? thanks!

block_stock_entrance = fields.Boolean(
help="if this box is checked, putting stock on this location won't be "
"allowed. Usually used for a virtual location that has "
"childrens."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"childrens."
"children."


block_stock_entrance = fields.Boolean(
help="if this box is checked, putting stock on this location won't be "
"allowed. Usually used for a virtual location that has "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be that use case solved by using view locations instead for parents ?

As Odoo avoid putting quants in views.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, the comment on this should be changed as you can:

  • Define WH/Stock as view

So, this module can be used in a generic way if you want to disallow the storage of products there temporarily (in a more permanent way, see above).

@@ -0,0 +1,12 @@
The aim of this module is to mark internal locations where no product
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be refactored as this module can be used in a more generic way.

Copy link

@luc-adhoc luc-adhoc Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rousseldenis !
From a functional perspective, what happens is that when defining the parent location as a view, it doesn't correctly display the nesting of the child locations in the list view. For this reason, the use case is presented for 'internal locations'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.