Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] stock_location_last_inventory_date: Make last_inventory_date storeable #2222

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[14.0][IMP] stock_location_last_inventory_date: Make last_inventory_date storeable #2222

merged 1 commit into from
Jan 22, 2025

Conversation

mt-software-de
Copy link
Contributor

@mt-software-de mt-software-de commented Dec 17, 2024 •
edited
Loading

I wanted to make this field searchable. At first i tried to create a search method for it, but it was not nice to implement, since the location of stock.inventory is used. Storing the date is easier. Therefor i changed the computation to use stock.inventory.line instead of stock.inventory , because this record contains a direct link to a location.

@mt-software-de mt-software-de changed the title [IMP] stock_location_last_inventory_date: Make last_inventory_data storeable [14.0][IMP] stock_location_last_inventory_date: Make last_inventory_data storeable Dec 17, 2024
@mt-software-de mt-software-de changed the title [14.0][IMP] stock_location_last_inventory_date: Make last_inventory_data storeable [14.0][IMP] stock_location_last_inventory_date: Make last_inventory_date storeable Dec 17, 2024
@mt-software-de mt-software-de force-pushed the 14-imp-stock_location_last_inventory_date branch from f07a99c to dbe1f5b Compare December 17, 2024 09:41
@mt-software-de
Copy link
Contributor Author

@hailangvn @sebalix @simahawk
Could you maybe review this one, since you did the migration for it?
#1261

@mt-software-de
Copy link
Contributor Author

cc @i-vyshnevska @jbaudoux

jbaudoux
jbaudoux requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make an inventory of a location without making any inventory line. I would have not changed that concept.
In newer versions, it's updating the date when the inventory is posted. You could go that way and make a migration script of the initialization of the field.

stock_location_last_inventory_date/models/stock_location.py Outdated Show resolved Hide resolved
@mt-software-de mt-software-de force-pushed the 14-imp-stock_location_last_inventory_date branch from dbe1f5b to dcdb125 Compare December 17, 2024 15:18
@mt-software-de mt-software-de force-pushed the 14-imp-stock_location_last_inventory_date branch from dcdb125 to 0e0121d Compare December 18, 2024 20:00
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@mt-software-de
Copy link
Contributor Author

can this be merged?

@jbaudoux
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-2222-by-jbaudoux-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1d5c782. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 07ac73d into OCA:14.0 Jan 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuwnevska vuwnevska vuwnevska approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mt-software-de @OCA-git-bot @jbaudoux @vuwnevska