-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending Concept Set Items with Annotations #2403
Changes from 14 commits
e6c3857
633eb78
757929a
83579dd
7e9359c
25f44ae
948fde3
0fff858
7adb69b
f40a666
2b9c35a
485b41a
937c72e
6a88e5d
deed559
1f6476c
4ee6b48
57491c3
4c3a304
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,7 @@ | |
* @author Anthony Sena <https://github.com/ohdsi> | ||
*/ | ||
|
||
@Entity(name = "ConceptSetGenerationInfo") | ||
@Entity | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above, please revert this change. |
||
@Table(name = "concept_set_generation_info") | ||
@IdClass(ConceptSetGenerationInfoKey.class) | ||
public class ConceptSetGenerationInfo implements Serializable { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,7 +29,7 @@ | |
* @author fdefalco | ||
*/ | ||
|
||
@Entity(name = "ConceptSetItem") | ||
@Entity | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above, we name Entities. |
||
@Table(name="concept_set_item") | ||
public class ConceptSetItem implements Serializable{ | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,108 @@ | ||
package org.ohdsi.webapi.conceptset.annotation; | ||
|
||
import org.hibernate.annotations.GenericGenerator; | ||
import org.hibernate.annotations.Parameter; | ||
import org.ohdsi.webapi.model.CommonEntity; | ||
|
||
import javax.persistence.Column; | ||
import javax.persistence.Entity; | ||
import javax.persistence.GeneratedValue; | ||
import javax.persistence.Id; | ||
import javax.persistence.Table; | ||
import java.io.Serializable; | ||
|
||
@Entity | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add name here. |
||
@Table(name = "concept_set_annotation") | ||
public class ConceptSetAnnotation extends CommonEntity<Integer> implements Serializable { | ||
/** | ||
* | ||
*/ | ||
private static final long serialVersionUID = 1L; | ||
|
||
@Id | ||
@GenericGenerator( | ||
name = "concept_set_annotation_generator", | ||
strategy = "org.hibernate.id.enhanced.SequenceStyleGenerator", | ||
parameters = { | ||
@Parameter(name = "sequence_name", value = "concept_set_annotation_sequence"), | ||
@Parameter(name = "increment_size", value = "1") | ||
} | ||
) | ||
@GeneratedValue(generator = "concept_set_annotation_generator") | ||
@Column(name = "concept_set_annotation_id") | ||
private Integer id; | ||
|
||
@Column(name = "concept_set_id", nullable = false) | ||
private Integer conceptSetId; | ||
|
||
@Column(name = "concept_id") | ||
private Integer conceptId; | ||
|
||
@Column(name = "annotation_details") | ||
private String annotationDetails; | ||
|
||
@Column(name = "vocabulary_version") | ||
private String vocabularyVersion; | ||
|
||
@Column(name = "concept_set_version") | ||
private String conceptSetVersion; | ||
|
||
@Column(name = "copied_from_concept_set_ids") | ||
private String copiedFromConceptSetIds; | ||
|
||
public Integer getId() { | ||
return id; | ||
} | ||
|
||
public void setId(Integer id) { | ||
this.id = id; | ||
} | ||
|
||
public Integer getConceptSetId() { | ||
return conceptSetId; | ||
} | ||
|
||
public void setConceptSetId(Integer conceptSetId) { | ||
this.conceptSetId = conceptSetId; | ||
} | ||
|
||
public Integer getConceptId() { | ||
return conceptId; | ||
} | ||
|
||
public void setConceptId(Integer conceptId) { | ||
this.conceptId = conceptId; | ||
} | ||
|
||
public String getAnnotationDetails() { | ||
return annotationDetails; | ||
} | ||
|
||
public void setAnnotationDetails(String annotationDetails) { | ||
this.annotationDetails = annotationDetails; | ||
} | ||
|
||
public String getVocabularyVersion() { | ||
return vocabularyVersion; | ||
} | ||
|
||
public void setVocabularyVersion(String vocabularyVersion) { | ||
this.vocabularyVersion = vocabularyVersion; | ||
} | ||
|
||
public String getConceptSetVersion() { | ||
return conceptSetVersion; | ||
} | ||
|
||
public void setConceptSetVersion(String conceptSetVersion) { | ||
this.conceptSetVersion = conceptSetVersion; | ||
} | ||
|
||
public String getCopiedFromConceptSetIds() { | ||
return copiedFromConceptSetIds; | ||
} | ||
|
||
public void setCopiedFromConceptSetIds(String copiedFromConceptSetIds) { | ||
this.copiedFromConceptSetIds = copiedFromConceptSetIds; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package org.ohdsi.webapi.conceptset.annotation; | ||
|
||
import java.util.List; | ||
import java.util.Optional; | ||
|
||
import org.springframework.data.jpa.repository.JpaRepository; | ||
import org.springframework.data.jpa.repository.Query; | ||
|
||
public interface ConceptSetAnnotationRepository extends JpaRepository<ConceptSetAnnotation, Integer> { | ||
|
||
@Query("DELETE FROM ConceptSetAnnotation cc WHERE cc.conceptSetId = :conceptSetId and cc.conceptId in :conceptId") | ||
void deleteAnnotationByConceptSetIdAndInConceptId(int conceptSetId, List<Integer> conceptId); | ||
|
||
void deleteAnnotationByConceptSetIdAndConceptId(int conceptSetId, int conceptId); | ||
|
||
List<ConceptSetAnnotation> findByConceptSetId(int conceptSetId); | ||
ConceptSetAnnotation findById(int id); | ||
void deleteById(int id); | ||
Optional<ConceptSetAnnotation> findConceptSetAnnotationByConceptIdAndConceptId(int conceptSetId, int conceptId); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
package org.ohdsi.webapi.security.model; | ||
|
||
import org.springframework.stereotype.Component; | ||
|
||
import java.util.HashMap; | ||
import java.util.Map; | ||
|
||
@Component | ||
public class ConceptSetAnnotationPermissionSchema extends EntityPermissionSchema { | ||
|
||
private static Map<String, String> writePermissions = new HashMap<String, String>() { | ||
{ | ||
put("conceptset:annotation:%s:delete", "Delete Concept Set Annotation with ID %s"); | ||
} | ||
}; | ||
|
||
private static Map<String, String> readPermissions = new HashMap<String, String>() { | ||
{ | ||
} | ||
}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is odd to me: Shouldn't the writePermissions contain all permissions related to creating annotations and the read have the ones related to reading annotations? |
||
|
||
public ConceptSetAnnotationPermissionSchema() { | ||
super(EntityType.CONCEPT_SET_ANNOTATION, readPermissions, writePermissions); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this as we have a convention to name the entity, you can see this in CohortDefinition, Source, etc.