NgapBuildDmrppContainer lifecycle changes from lcfo-2023 #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
jgallagher59701
approved these changes
May 28, 2024
|
@ndp-opendap What is the status of this PR? Should it be merged or dropped? |
|
It was never review. It's possible this idea is worthy, or it may be junk. Given the c++ situation in general this would require careful review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to stop the container from hanging onto a shared pointer to an object which keeps a file open until the next request.
Imported lifecycle changes for
NgapBuildDmrppContainerfromlcfo-2023It is entirely possible that this attempt is just wrong. At the point I wonder if we couldn't just get the container at the end of the transmission and call release() on the shared_ptr