Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the logic of the application of the data in
resources/data/custom_nodes
.resources/data/custom_nodes
will overwrite the data pulled from other sources in the main workflow (e.g. from PLEXOS-World) disregarding whether thenodes_to_add
parameter is defined or not. Previously input files were only called if thenodes_to_add
parameter was defined in the config file.resources/data/custom_nodes
was inconsistent. E.g. for some input files only the data was pulled for new nodes that were defined innodes_to_add
(e.g.resources/data/custom_nodes/residual_capacity
) whereas for others ALL data was applied including for existing nodes (e.g.resources/data/custom_nodes/RE_potentials
). In this update the default is that ALL data that is defined in the folder will overwrite the base data.custom_nodes
folder has more or less become acustom_data
folder.resources/data/custom_nodes
for nodes that are not within thegeographic_scope
ornodes_to_add
it will trigger a fail of the workflow. This is deliberate as it is up to the users to define custom data. Having existing custom data (e.g. legacy data from TZ) without proper description is not something we should want.TotalAnnualMaxCapacityInvestment
within the storage rule.