Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test cases for slackbot homepage #384

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Added test cases for slackbot homepage #384

merged 5 commits into from
Jan 10, 2025

Conversation

Rajgupta36
Copy link
Collaborator

Resolves #361

Added test cases for slackbot home page

@Rajgupta36 Rajgupta36 requested a review from arkid15r as a code owner January 9, 2025 00:34
@Rajgupta36 Rajgupta36 changed the title add_test_cases_for_slackbot Added test cases for slackbot homepage Jan 9, 2025
arkid15r
arkid15r requested changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove obvious comments

backend/tests/slack/actions/home_tests.py Outdated Show resolved Hide resolved
backend/tests/slack/actions/home_tests.py Outdated Show resolved Hide resolved
backend/tests/slack/actions/home_tests.py Outdated Show resolved Hide resolved
arkid15r
arkid15r approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arkid15r arkid15r enabled auto-merge January 10, 2025 18:10
@arkid15r arkid15r added this pull request to the merge queue Jan 10, 2025
Merged via the queue into OWASP:main with commit 3a9af3c Jan 10, 2025
12 checks passed
@Rajgupta36 Rajgupta36 deleted the slack_test branch January 10, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r approved these changes

Assignees
No one assigned
Labels
backend nestbot-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NestBot home page tests
2 participants
@Rajgupta36 @arkid15r