Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added /leaders NestBot command #399

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Conversation

Rajgupta36
Copy link
Collaborator

Resolves #362

Checklist:

  • Implemented the /leaders command.
  • Updated search routes.
  • Updated searchable attributes for index.
  • Added test cases.

@nitinawari
Copy link
Collaborator

hey @Rajgupta36 checkout some suggestion from my side

@abhayymishraa
Copy link
Collaborator

@nitinawari btw what do you suggest?

@Rajgupta36
Copy link
Collaborator Author

Rajgupta36 commented Jan 10, 2025

hey @Rajgupta36 checkout some suggestion from my side

?

backend/apps/slack/commands/leaders.py Outdated Show resolved Hide resolved
backend/apps/slack/commands/leaders.py Show resolved Hide resolved
@nitinawari
Copy link
Collaborator

@Rajgupta36 hey i really sorry forget to click on submit review . check it out two suggestions

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rajgupta36 @nitinawari I improved the code a bit
Please review and test when you get a chance

@arkid15r arkid15r enabled auto-merge January 10, 2025 17:01
@Rajgupta36
Copy link
Collaborator Author

@Rajgupta36 @nitinawari I improved the code a bit Please review and test when you get a chance

it works well . thanks @arkid15r for adding changes.

@Rajgupta36 Rajgupta36 requested a review from nitinawari January 10, 2025 17:09
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this, thanks @Rajgupta36

@nitinawari thanks for review!

@arkid15r arkid15r added this pull request to the merge queue Jan 10, 2025
Merged via the queue into OWASP:main with commit 53c6783 Jan 10, 2025
12 checks passed
@Rajgupta36 Rajgupta36 deleted the slackbot_/leaders branch January 10, 2025 17:16
@nitinawari nitinawari mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement /leaders NestBot command
4 participants