Fixed a dependency and added a directory for the config #4
Conversation
aimbot31
force-pushed
the
fix-kubernetes
branch
from
d1041d0 to
ed4af61
Compare
| && mkdir /etc/cloudkitty \ | ||
| && mkdir \ | ||
| /etc/cloudkitty \ | ||
| /etc/cloudkitty-config \ |
There was a problem hiding this comment.
Why not simply /config ? would be simpler to use
There was a problem hiding this comment.
I'm not a huge fan of just /config, i don't want to break too many habits when switching from ck −> ck on docker.
There was a problem hiding this comment.
You don't switch from pure ck to ck on docker, you switch from one automated deployment method (OSA, kolla-ansible, anything). You rarely directly edit /etc/cloudkitty/config_x. And even if you want to edit stuff in /etc/cloudkitty, there are symbolic links now
CloudKitty/api/Dockerfile
Outdated
| /etc/cloudkitty-config \ | ||
| && ln -sf \ | ||
| /etc/cloudkitty/cloudkitty.conf \ | ||
| /etc/cloudkitty-config/cloudkitty.conf \ |
There was a problem hiding this comment.
We also need a symbolic link for metrics.yml then
CloudKitty/processor/Dockerfile
Outdated
| @@ -1,5 +1,6 @@ | |||
| FROM python:3.7-buster | |||
|
|
|||
| RUN pip install cloudkitty | |||
| RUN pip install cloudkitty \ | |||
There was a problem hiding this comment.
wanted to align with the cmd below
README.md
Outdated
| - `/etc/cloudkitty/cloudkitty.conf` | ||
| - `/etc/cloudkitty-config/cloudkitty.conf` | ||
|
|
||
| *If you want to deploy this application on kubernetes, the second location could be useful.* |
There was a problem hiding this comment.
- I'd rather have only one way to do things. eg; "Mount your custom cloudkitty.conf and metrics.yml files to
/xxx" .
Users usually do weird things when they have a choice 😉
There was a problem hiding this comment.
standardize this could be a good idea
README.md
Outdated
| - `/etc/cloudkitty/cloudkitty.conf` | ||
| - `/etc/cloudkitty-config/cloudkitty.conf` | ||
|
|
||
| *If you want to deploy this application on kubernetes, the second location could be useful.* |
There was a problem hiding this comment.
- I'd rather have only one way to do things. eg; "Mount your custom cloudkitty.conf and metrics.yml files to
/xxx" .
Users usually do weird things when they have a choice 😉
aimbot31
force-pushed
the
fix-kubernetes
branch
from
ed4af61 to
9c9ab35
Compare
|
Should be good |
aimbot31
force-pushed
the
fix-kubernetes
branch
2 times, most recently
from
ef94090 to
cb7c8c3
Compare
In order to have compatibility between CloudKitty and Kubernetes, we need to have a repository for processing the ConfigMap. There where a problem with PyMySQL which where missing. Updated the readme to explain where to put the config
aimbot31
force-pushed
the
fix-kubernetes
branch
from
cb7c8c3 to
f409751
Compare
aimbot31
changed the title
In order to have compatibility between CloudKitty
and Kubernetes, we need to have a repository
for processing the ConfigMap.
There where a problem with PyMySQL which
where missing.
Updated the readme to explain where to put the config