Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mean-eddy decomposition function to utils #8

Merged
merged 9 commits into from
Jun 9, 2021
Merged

Conversation

dantecn
Copy link
Member

@dantecn dantecn commented Jun 2, 2021

No description provided.

@iuryt
Copy link
Member

iuryt commented Jun 5, 2021

Should we add this parallel_client? Isn't better just give an example on documentation?

@dantecn
Copy link
Member Author

dantecn commented Jun 7, 2021

Should we add this parallel_client? Isn't better just give an example on documentation?

Is there a way to have the function defined (so we may call it from other functions), but not available to users? Removing it from __init__ would do the trick?

@iuryt
Copy link
Member

iuryt commented Jun 8, 2021

Should we add this parallel_client? Isn't better just give an example on documentation?

Is there a way to have the function defined (so we may call it from other functions), but not available to users? Removing it from __init__ would do the trick?

Usually, functions like this are defined with underscore in other packages ._parallel_client

@dantecn
Copy link
Member Author

dantecn commented Jun 9, 2021

Should we add this parallel_client? Isn't better just give an example on documentation?

Is there a way to have the function defined (so we may call it from other functions), but not available to users? Removing it from __init__ would do the trick?

Usually, functions like this are defined with underscore in other packages ._parallel_client

Should it be an isolated function, like ls OceanLab
dyn.py eof.py __init.py__ oa.py utils.py ._parallel_client,
or do I create a support.py containing ._parallel client only to be imported by dyn.py etc?

@MariaMigl
Copy link
Collaborator

With that approach I believe you can still keep it in the same file(module). However in this case if possible to make it not able to import at all I think it makes more sense than the dunder approach

@dantecn dantecn merged commit 2b170e7 into master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants