Skip to content

OCG Audit Remediations #28

OCG Audit Remediations

OCG Audit Remediations #28

Triggered via pull request October 17, 2024 16:43
@OightyOighty
synchronize #13
ocg-upgrade
Status Failure
Total duration 2m 7s
Artifacts

CI.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 12 warnings
run-ci
Process completed with exit code 1.
run-ci
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-node@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
run-ci
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v2, pnpm/action-setup@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
run-ci: src/external/cooler/Cooler.sol#L2
Found more than One contract per file. 2 contracts found!
run-ci: src/external/cooler/CoolerCallback.sol#L15
Immutable variables name are set to be in capitalized SNAKE_CASE
run-ci: src/external/cooler/CoolerFactory.sol#L39
Immutable variables name are set to be in capitalized SNAKE_CASE
run-ci: src/external/governance/abstracts/GovernorBravoStorage.sol#L2
Found more than One contract per file. 3 contracts found!
run-ci: src/external/governance/GovernorBravoDelegator.sol#L51
Use Custom Errors instead of require statements
run-ci: src/external/governance/GovernorBravoDelegator.sol#L52
Use Custom Errors instead of require statements
run-ci: src/external/governance/GovernorBravoDelegator.sol#L83
Fallback function must be simple
run-ci: src/external/OlympusAuthority.sol#L2
Found more than One contract per file. 3 contracts found!
run-ci: src/external/OlympusAuthority.sol#L54
Use Custom Errors instead of require statements
run-ci: src/external/OlympusAuthority.sol#L59
Use Custom Errors instead of require statements