Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: remappings, proposal testing, fork tests #20

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Fix: remappings, proposal testing, fork tests #20

merged 6 commits into from
Nov 12, 2024

Conversation

0xJem
Copy link
Collaborator

@0xJem 0xJem commented Nov 12, 2024

Minor fixes:

  • Something in forge broke remappings, so the paths are updated
  • Split proposal tests into a separate CI job
  • Pin blocks in fork tests

0xJem added 5 commits November 12, 2024 17:28
@0xJem
Cross-port remappings fixes from commit 7599f27
0f78896 
# Conflicts:
#	src/test/policies/EmissionManager.t.sol
#	src/test/policies/Heart.t.sol
#	src/test/policies/ReserveMigrator.t.sol
#	src/test/proposals/EmissionManagerProposal.t.sol
#	src/test/proposals/OIP_168.t.sol
#	src/test/sim/RangeSim.sol
@0xJem
Cross-port script improvements from #18
1b02338
@0xJem
Rename fork test to be recognised correctly
5891efc
@0xJem
Cross-port BLV fork test improvements from #19
7d89718
@0xJem
Cross-port separate OCG job from #19
5a1189c
@0xJem 0xJem self-assigned this Nov 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

LCOV of commit 569643a during CI #42

Summary coverage rate:
  lines......: 69.4% (1365 of 1966 lines)
  functions..: 72.2% (296 of 410 functions)
  branches...: no data found

Files changed coverage rate: n/a

@0xJem
Copy link
Collaborator Author

0xJem commented Nov 12, 2024

No contract changes, only script/test improvements. Merging.

@0xJem 0xJem merged commit 35b572a into develop Nov 12, 2024
2 checks passed
@0xJem 0xJem deleted the remappings-fix branch November 12, 2024 13:45
@0xJem 0xJem mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0xJem 0xJem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0xJem