Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook updates and addition of US-CRT config file #7

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

inkenbrandt
Copy link
Contributor

  • Update example notebooks and delete redundant license files
  • Made modifications to the example notebooks to improve readability and code execution. These changes improve code organization and module imports, and enhance the use case guide for the users. This includes dynamic references to the python files in the scripts folder.
  • Fixed deprecation issues with the pyproj function calls in the example notebooks
  • Created a Config file for US-CRT, and fixed custom variable additions.

This has been tested using the notebooks.

Made modifications to the example notebooks to improve readability and code execution. These changes improve code organization and module imports, and enhance the use case guide for the users.

Fixed deprecation issues with the pyproj function calls.

Created a Config file for US-CRT, and fixed custom variable additions.
@JohnVolk JohnVolk self-assigned this Apr 1, 2024
Made modifications to the example notebooks to improve readability and code execution. These changes improve code organization and module imports, and enhance the use case guide for the users.

Fixed deprecation issues with the pyproj function calls.

Created a Config file for US-CRT, and fixed custom variable additions.
Variable names within the FFPCalc class have been refactored to be singular rather than plural, enhancing readability. Colormap handling has been modified to use direct matplotlib colormap access instead of the "cm" module. Smooth kernel declaration has been changed from matrix to an array to ensure proper data format compatibility.
This commit introduces a script for parallel processing preformatted time series input data needed for the Kljun et al. 2D flux footprint prediction code. It includes data checks, automatic download, and weighted data normalization. Intended for scientific purposes to document employed workflows.
This commit introduces a script for parallel processing preformatted time series input data needed for the Kljun et al. 2D flux footprint prediction code. It includes data checks, automatic download, and weighted data normalization. Intended for scientific purposes to document employed workflows.
@JohnVolk
Copy link
Collaborator

Hey Paul, can you please share the full environment you are using? I'm having some issues with one of the example notebooks and I am not sure if it is due to different package versions or something else. Just to be clear, when you tested using the AmeriFlux data the resulting example plots in the notebook looked exactly as they did before the changes?

@inkenbrandt
Copy link
Contributor Author

I refactored the calc_footprint_FFP_climatology.py into a new class in ffp.py, so that is likely the issue. I also added some basic tests. The celery notebook links to the new class.

The ffp.py file was refactored, notably changing how matplotlib is imported and how certain calculations are performed. A new unit test file, test_ffp.py, was added to verify correct behavior after the refactor. Additionally, small changes were also made to a jupyter notebook to match with the current ffp.py state.
The ffp.py file was refactored, notably changing how matplotlib is imported and how certain calculations are performed. A new unit test file, test_ffp.py, was added to verify correct behavior after the refactor. Additionally, small changes were also made to a jupyter notebook to match with the current ffp.py state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants