-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing packaging version #3764
Conversation
I think the better solution will be to change:
to
And then add packaging^22. Thoughts? |
@jmaslek agreed and changed |
Does the Tests / General Linting create a fresh environment each time? The error does not make sense since |
It uses the actions/cache@v3 to restore dependencies. I am not sure how to change those, so you may need to just add |
It creates a fresh env when the dep tree is re-solved |
The tests create a new env, but the linting uses the cache from gh actions. That has not been updated in 9 months. I used this doc to open a new PR that will edit the cache when the poetry lock changes: https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows |
This PR patch the deprectation of
LegacyVersion
underpackaging
- also discussed here: pypa/packaging#631LegacyVersion
packaging=">=22.0"
Steps taken:
Fix: